Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 173451

Summary: Verification on Shell in Linux ia 32 does not generate expected code
Product: z_Archived Reporter: Liz Dancy <lizdancy>
Component: TPTPAssignee: Liz Dancy <lizdancy>
Status: CLOSED FIXED QA Contact:
Severity: major    
Priority: P1 CC: amehrega, jkubasta, paulslau
Version: unspecifiedKeywords: plan
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
Proposed Patch
none
Second version of the patch none

Description Liz Dancy CLA 2007-02-08 09:55:46 EST 
Steps To Reproduce:
1. On Linux ia_32, create a test case which opens the log import dialog.
2. Type in a verificatoin hook name and insert
3. You will notice that it takes a few seconds to accept the verification name and then allows the insert but the method is not generated in the verification hook class.

Verifications on Editors and ViewParts work as expected.
Comment 1 amehrega CLA 2007-02-08 10:31:30 EST 
Try looking into the workspace log file.  If the status reported on the control dialog does not report an error, then there is likely a problem while generating the code.

The window manager on Linux behaves differently than on Windows.  This problem can also be caused by the code path that is different on Linux compared to Windows.
Comment 2 amehrega CLA 2007-02-08 10:32:44 EST 
You may want to increase the priority of this defect.  I would try to get it into the second iteration of 4.4.
Comment 3 Liz Dancy CLA 2007-02-08 11:40:08 EST 
Updated sizing
Comment 4 Liz Dancy CLA 2007-02-08 11:56:06 EST 
Setting to 4.4i2 target, P1.
Comment 5 Liz Dancy CLA 2007-02-16 13:52:42 EST 
Verified that this is still happening in the first 4.4 test pass.
Comment 6 Liz Dancy CLA 2007-03-14 15:54:05 EDT 
Created attachment 60853 [details]
Proposed Patch

I am attaching a proposed patch which handles the case on Linux where the control had been disposed before the status was updated. It keeps the same status updates but changes the reference for this case only. I have tested it on Windows and Linux but would greatly appreciate it Ali if you could review it on Windows as well.
Comment 7 amehrega CLA 2007-03-15 09:58:30 EDT 
Created attachment 60937 [details]
Second version of the patch

Liz,

The patch looks good.  There was just a system println statement that I removed from the original patch.
Great work!
Comment 8 Liz Dancy CLA 2007-03-16 08:54:36 EDT 
Patch checked in to HEAD.
Comment 9 Paul Slauenwhite CLA 2007-06-02 14:51:41 EDT 
Reporter: Please verify and close in preparation for shutting down the TPTP 4.4 release.  Thanks.
Comment 10 Liz Dancy CLA 2007-06-04 10:54:01 EDT 
I have verified this fix on the TPTP 200705310943 driver.
Comment 11 Liz Dancy CLA 2007-06-04 10:54:11 EDT 
Closing.