Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 173369

Summary:	SelectionSynchronizer should support not revealing a selection
Product:	[Tools] GEF	Reporter:	Tamar Cohen <tamar.e.cohen>
Component:	GEF-Legacy GEF (MVC)	Assignee:	Alexander Nyßen <nyssen>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	nyssen
Version:	unspecified
Target Milestone:	3.10.0 (Mars) M1
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Tamar Cohen

2007-02-07 18:41:36 EST

I have a graphical viewer and a Tree Outline which are synchronized via a SelectionSynchronizer.  The users of my product don't want my ScrollingGraphicalViewer to change the scrolled location when they select a different element from the Tree Outline.

In looking into making this improvement, I noticed that the selectionChanged method of the SelectionSynchronizer class ends up calling viewer.reveal in the private setViewerSelection function.

I suggest either
(a) redesigning this class so it is designed to be sublcassed, so these functions can be overridden or
(b) adding a settable flag for revealing (or not) on selection.

Comment 1 Alexander Nyßen

2014-08-09 04:28:22 EDT

Opened up SelectionSynchronizer for subclassing, by applying the following changes:
    
- Renamed setViewerSelection() to applySelection() and made it protected.
- Made syncSelection() protected.

Pushed all changes to origin/master. Resolving as fixed in 3.10.0M1.