Bugzilla – Full Text Bug Listing
| Summary: | [relengtool] "Fix Copyrights" action is mis-named, is IBM-specific, ignores template | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Walter Harley <eclipse> |
| Component: | Releng | Assignee: | Platform-Releng-Inbox <platform-releng-inbox> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P5 | CC: | david_williams, dj.houghton, eclipse, jeffmcaffer, johans, kim.moir, markus.kell.r, Michael.Valenta, mober.at+eclipse |
| Version: | 3.3 | Keywords: | helpwanted |
| Target Milestone: | 3.5 RC1 | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Whiteboard: | |||
|
Description
Walter Harley
(In reply to comment #1) > See also bug 77026. Thanks, David - yes, I also was getting bit because I use Package Explorer rather than Navigator. So: 1. It would be good to make the Advanced action show up in both views. 2. The ellipsis should be removed from both actions. 3. The customizations requested in bug 77026 would be very nice, for the reasons expressed there. I am in the process of modifying the releng tools to handle the new map file format so since I am in that space if I get time I will look into the copyright part of it. fyi: it looks like the Fix Copyright code is commented out with "disable fix up existing copyright till it works better". :-) *** Bug 149834 has been marked as a duplicate of this bug. *** This is still an issue in the latest releng tools. Using the Fix Copyrights menu option you get the IBM copyright (hardcoded as best I can tell). Using the Advanced Copyright fix tool from the NAVIGATOR you get thr right behaviour. Is ther eany reason we have two? Can someone just swap out the old menu entry and put in the new? I suspect the reason there are two is because users of the Advanced Fix Copyright action don't have the time to verify that it works properly for the old Fix Copyright action. Since I don't have time either, I have renamed the Advanced Fix Copyright action to just Fix Copyright and the Eclipse/IBM specific on to Eclipse/IBM Fix Copyright. This should make it clear which on non-Eclipse or non-IBM users should use. A brilliant solution :-) Thanks, Michael. Is this change going to be released into 3.5 ? At the moment it just sits in HEAD... That would be up to the component lead I guess. Kim, do you want to release this change for 3.5? It just renames the two actions so things are more clear (or as clear as they can be through the limited text in an action name). tagged for next i-build. Just as a heads up, the big remaining difference I believe between the two actions is that the "IBM fix copyrights" will search your CVS history, and ignore commits that include the word "copyright" in it. This saves you from updating the copyright to a newer year just because the copyright were updated in that year (this causes copyrights to ripple and require updating every year). If a non-IBM committer cares about this and fixes the "Advanced fix copyrights" to do the same, then I suspect we can turf the old one completely. I have a vague recollection that there was another element of this: the IBM one requires CVS whereas not everyone uses CVS. So if someone does get up the energy to do the change please make it somehow optional so that people not using CVS can still get at least rudimentary support. Actually, the Advanced version was modified to delegate the determination of the year to the repository provider. This allows the repository providers to determine what files have changed by comparing to a particular base (e.g. tag). This wasn't implemented for CVS but could be. Sorry, I was a bit off on my last comment. The advanced version uses an interface that can be implemented by the repository provider to provide the modification year. This includes an initialization call to the repository provider that allows for the caching of the modification years. However, the CVS integration was not optimized to make use of this. For CVS this initialization could prompt for the text to look for in the commit comment or, better yet, could prompt for a tag to compare against to find files changed since the last release. *** Bug 180767 has been marked as a duplicate of this bug. *** |