Bug 173361

Description Linda Damus 2007-02-07 17:41:52 EST

The Undo (and Redo) menu items use the wrong undo context after the user switches workbench parts.  The incorrect operation history is presented to the user until the next undoable change is made in the diagram editor.

The problem is that the GlobalUndoAction (and GlobalRedoAction) creates a new Eclipse UndoActionHandler delegate whenever the workbench part changes.  In Eclipse 3.3M4 (see bug 162964) the UndoActionHandler has a 'contextActive' state that is false when a new handler is created.  The UndoActionHandler#getUndoContext returns the global undo context for the workbench until the its real context is deemed active.

Steps to reproduce the problem in the logic example:
1. Launch a new workbench and open the resource perspective
2. Create a simple project
3. Create an example logic diagram.  Observe that the undo menu item when the diagram is selected is "Undo New Project".
4. Add a new circuit to the diagram using the tool palette.  Now the undo menu item says "Undo Create Circuit"
5. Change focus to the Outline view, then back to the diagram view.  Now the undo menu item is "Undo New Project". It should be "Undo Create Circuit"
5. Create an LED using the tool palette.  Undo.  Observe that the undo menu item is correctly back to "Undo Create Circuit"