Bugzilla – Full Text Bug Listing
| Summary: | [EditorMgmt] "Open With > Other..." dialog should set focus on the list on open | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Markus Keller <markus.kell.r> | ||||||||||||
| Component: | UI | Assignee: | Markus Keller <markus.kell.r> | ||||||||||||
| Status: | VERIFIED FIXED | QA Contact: | Remy Suen <remy.suen> | ||||||||||||
| Severity: | normal | ||||||||||||||
| Priority: | P3 | CC: | b.muskalla, daniel_megert, georg.sendt | ||||||||||||
| Version: | 3.3 | ||||||||||||||
| Target Milestone: | 3.7 M4 | ||||||||||||||
| Hardware: | All | ||||||||||||||
| OS: | All | ||||||||||||||
| Whiteboard: | |||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Markus Keller
Remy is now responsible for watching the [EditorMgmt] component area. *** Bug 259227 has been marked as a duplicate of this bug. *** Created attachment 159378 [details]
EditorSelectionDialog patch v1
Work in progress against v1.9 of EditorSelectionDialog.
Created attachment 164741 [details]
EditorSelectionDialog patch v2
Work in progress against v1.11 of EditorSelectionDialog.
Created attachment 182717 [details]
Screenshot depicting the change in question.
What do you think about the use of a FilteredTree, Markus?
Technically, it's a flat list and not a tree but I noticed we don't actually have a FilteredTable control.
The tabs are looking good, but the tree widget looks ugly in that screenshot. You would at least have to create it with SWT.FULL_SELECTION to make the dotted lines go away. I would either leave the table, or spend more time on this and create a FilteredTable (of course not copying the FilteredTree but separating the filtering from the concrete widget and then use the same filtering logic for both widgets). But way more important than that would be to fix bug 173759. Created attachment 182753 [details]
EditorSelectionDialog patch v3
Patch to switch the dialog to use tabs.
(In reply to comment #8) > Created an attachment (id=182753) [details] > EditorSelectionDialog patch v3 Patch released to CVS HEAD. I'll hold off on the filtering for now. Dani just said to me that tabs could be a bit confusing, since you can have different selections on the two pages, and it's not clear that the selection in the hidden tab has no significance (especially when the dialog is opened from the preference page). I dug a bit further and found this UI guideline, which explicitly recommends radio buttons for such situations: http://msdn.microsoft.com/en-us/library/aa511493.aspx#exclusive Sorry for the hassle, but I now agree you should revert the change to use tabs and just fix the initial focus issue for now. Filtering can be addressed with bug 69200 (and is not a big issue, since it's just a flat and sorted list). (In reply to comment #10) > Sorry for the hassle, but I now agree you should revert the change to use tabs > and just fix the initial focus issue for now. Noted, I will revert the change some time this week. May not get to the focus problem just yet though. Thanks for the investigation, Markus and Dani. (In reply to comment #11) > Noted, I will revert the change some time this week. I have reverted the code. Created attachment 183292 [details]
Fix for focus problem
The only thing left to do is fixing the initial focus. The patch does that and also remembers the current selection for each mode separately.
Remy, if you're OK with that, please release the patch, or assign the bug to me and I'll release it.
(In reply to comment #13) > Remy, if you're OK with that, please release the patch, or assign the bug to me > and I'll release it. This looks good to me. Thanks, Markus. Please feel free to release the patch at your prerogative. Fixed in HEAD. Verified in I20101206-1800. Not all changes made it into the 4.x stream. Manually cherry-picked now : Commit 10dfb6088cdb013a669d1d4f63ed4557c9792703 |