Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 172744

Summary: Incomplete manifest generated by ODA New Plugin Wizard in PDE 3.3M4
Product: [Tools] Data Tools Reporter: Linda Chan <lchan>
Component: Open Data AccessAssignee: Linda Chan <lchan>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: jasonweathersby
Version: 1.0   
Target Milestone: 1.5RC0   
Hardware: PC   
OS: Windows 2000   
Whiteboard:

Description Linda Chan CLA 2007-02-02 19:56:01 EST
When using the ODA New Plug-in Wizard to generate an ODA plug-in project with Platform PDE 3.3M4, the generated manifest.mf is missing a couple of entries.  They are generated properly when used with earlier versions of PDE.

The missing manifest.mf entries are:
* "Bundle-Localization: plugin" 
   As a result, it does not know to use the plugin.properties for externalized strings.
*  Export-Package entry for its impl package
    It causes Access Restriction compiler error in the corresponding generated ODA Designer plugin.
Comment 1 Linda Chan CLA 2007-02-08 18:18:42 EST
A symptom that an user would encounter is that he will not be able to go to the New Data Source wizard pages for the new ODA driver in BIRT; i.e. the NEXT button is disabled.
This is due to the missing "Bundle-Localization: plugin" line in the manifest.mf of both generated projects, which cause the generated data source id to not match between the new ODA runtime and design-time plug-ins.
Comment 2 Linda Chan CLA 2007-02-09 00:08:28 EST
This bug is caused by changes in PDE UI Template 3.3M4 build, which stops generating the 2 headers in the manifest.mf file (see PDE discussion in Bugzilla 173393 https://bugs.eclipse.org/bugs/show_bug.cgi?id=173393 ).

Implemented an interim fix in M5 to adjust the bundle headers in plugin model to trigger generation of needed entries in manifest.mf.  This unfortunately forces the use of internal PDE API to work around the PDE UI Template API's restrictions.

This bug is left open in M6 for tracking purpose.  May need further source changes in Europa, depending on the resolution to Bugzilla 173393.
Comment 3 Linda Chan CLA 2007-03-27 18:39:30 EDT
The PDE template wizard has fixed the "Bundle-Localization: plugin" bug in M6.  The second bug in missing Export-Package entry is supposingly fixed (according to Bug 173393), but apparently did not make it into the Platform M6 release build  I20070323-1616. 

I'd now removed the temporary work-around for the "Bundle-Localization: plugin" bug, but keep the work-around for "Export-Package" in DTP M6 build.

Leaving this bug open in RC0, till the PDE Export-Package bug fix is verified.
Comment 4 Linda Chan CLA 2007-05-03 21:07:54 EDT
Verified the PDE Export-Package bug fix (bug 173393) in Platform 3.3M7/RC0's integration build I20070503_0842.
PDE template now expects an export library's content filter to end with ".*".
Changed export package's filter name accordingly, and took out work-around implementation.
Comment 5 Brian Fitzpatrick CLA 2008-07-01 17:37:29 EDT
Closing bugs