Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 172734

Summary: [PropertiesDialog] PropertyDialogAction.isApplicableForSelection does not consider if the page is applicable
Product: [Eclipse Project] Platform Reporter: Darin Swanson <Darin_Swanson>
Component: UIAssignee: Tod Creasey <Tod_Creasey>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: kjdoyle, n.a.edgar, Tod_Creasey
Version: 3.3   
Target Milestone: 3.4 M3   
Hardware: PC   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 189162    
Attachments:
Description Flags
proposed patch none

Description Darin Swanson CLA 2007-02-02 17:56:28 EST 
PropertyDialogAction.isApplicableForSelection returns true no matter if none of the IPropertyPageContributor are applicable to the object (return true for isApplicableTo(Object).

I would propose the implementation of PropertyDialogAction.isApplicableForSelection should use PropertyPageContributorManager.getApplicableContributors
Comment 1 Darin Swanson CLA 2007-08-22 17:17:54 EDT 
Created attachment 76717 [details]
proposed patch
Comment 2 Tod Creasey CLA 2007-10-11 14:12:57 EDT 
I have also updated the javadoc of isApplicableForSelection . Patch released for build >20071011
Comment 3 Darin Swanson CLA 2007-10-11 14:30:31 EDT 
Thanks Tod.
Comment 4 Tod Creasey CLA 2007-10-29 14:07:50 EDT 
Verified in I20071029-0100
Comment 5 Martin Oberhuber CLA 2008-02-05 13:06:45 EST 
*** Bug 189162 has been marked as a duplicate of this bug. ***