Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 172283

Summary:	No code completion after a special line comment
Product:	z_Archived	Reporter:	Gadi Goldbarg <gadi>
Component:	PDT	Assignee:	Roy Ganor <ganoro>
Status:	CLOSED FIXED	QA Contact:	Yossi Luson <yossi.l>
Severity:	normal
Priority:	P2	Keywords:	plan
Version:	unspecified
Target Milestone:	---
Hardware:	All
OS:	Windows XP
Whiteboard:

Description Gadi Goldbarg

2007-01-31 04:02:32 EST

1. Paste the following code
2. <?
/**
 * @param $nbc
 */
function abc($nbc){}
//---- End Of Code ---->
|
?>
3. Hit Ctrl+space to start code completion - doesn't start
4. When I delete the > sign it works

Comment 1 Michael Spector

2007-02-17 03:38:27 EST

Fixed in CVS.

Comment 2 Gadi Goldbarg

2007-02-18 10:38:26 EST

Yosi.l: This bug is not fixed yet

Comment 3 Michael Spector

2007-02-19 15:31:09 EST

This bug happens accidently, if you stay right after '---->', press Enter (without saving!), and then CTRL+Space - code completion works...

We have to check why phpScriptRegion.isLineComment(relativeOffset) returns LINE_COMMENT, instead of WHITESPACE, even though the cursor is standing at the next line after line comment. Roy, can you check?

Comment 4 Roy Ganor

2007-02-20 04:28:24 EST

Fixed,

the reparser is fixed (lexer states were updated incorrectly)

Comment 5 Gadi Goldbarg

2007-02-20 11:53:30 EST

verified - to test with last tag

Comment 6 Gadi Goldbarg

2007-02-20 16:54:48 EST

fixed