Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 172243

Summary:	Remote Import: NPE thrown if cancel logon dialog
Product:	z_Archived	Reporter:	Jane Fang <janefang>
Component:	TPTP	Assignee:	Alex Nan <apnan>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P1	CC:	ewchan, jkubasta, labadie
Version:	unspecified	Keywords:	plan
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:	closed460

Description Jane Fang

2007-01-30 17:04:42 EST

Build: tptp.sdk-TPTP-4.4.0-200701080100.zip

1. import a log from a secured host
2. click No when asked if save certificate
3. click OK when asked if proceed
4. click Cancel when prompted for password
5. an error message pops up, and the reason is NPE.



!ENTRY org.eclipse.tptp.platform.common 1 0 2007-01-30 17:01:49.049
!MESSAGE java.lang.NullPointerException
!STACK 0
java.lang.NullPointerException
	at org.eclipse.tptp.monitoring.logui.internal.wizards.ConnectUtilUserWrapper.getName(ConnectUtilUserWrapper.java:16)
	at org.eclipse.tptp.monitoring.log.internal.core.SecureConnectUserWrapper.getName(SecureConnectUserWrapper.java:15)
	at org.eclipse.hyades.security.internal.util.BaseConnectUtil.connect(BaseConnectUtil.java:316)
	at org.eclipse.hyades.security.internal.util.BaseConnectUtil.connectConnection(BaseConnectUtil.java:355)
	at org.eclipse.tptp.monitoring.log.internal.core.RemoteImportHandler.connect(RemoteImportHandler.java:145)
	at org.eclipse.tptp.monitoring.logui.internal.wizards.ImportLogWizard.importFromRemoteHost(ImportLogWizard.java:2000)
	at org.eclipse.tptp.monitoring.logui.internal.wizards.ImportLogWizard.importLog(ImportLogWizard.java:1858)
	at org.eclipse.tptp.monitoring.logui.internal.wizards.ImportLogWizard.run(ImportLogWizard.java:322)
	at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:67)
	at org.eclipse.tptp.monitoring.logui.internal.wizards.ImportLogWizard.performFinish(ImportLogWizard.java:243)
	at org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:695)
	at org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:367)
	at org.eclipse.jface.dialogs.Dialog$3.widgetSelected(Dialog.java:638)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:90)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:928)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3465)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3079)
	at org.eclipse.jface.window.Window.runEventLoop(Window.java:820)
	at org.eclipse.jface.window.Window.open(Window.java:796)
	at org.eclipse.tptp.monitoring.logui.internal.actions.ImportLogAction.run(ImportLogAction.java:57)
	at org.eclipse.jface.action.Action.runWithEvent(Action.java:499)
	at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:545)
	at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:490)
	at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:402)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:928)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3465)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3079)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1945)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1909)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:425)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.eclipse.ui.internal.ide.IDEApplication.run(IDEApplication.java:95)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at org.eclipse.equinox.internal.app.EclipseAppContainer.callMethod(EclipseAppContainer.java:522)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:147)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:104)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:74)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:170)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at org.eclipse.core.launcher.Main.invokeFramework(Main.java:339)
	at org.eclipse.core.launcher.Main.basicRun(Main.java:283)
	at org.eclipse.core.launcher.Main.run(Main.java:984)
	at org.eclipse.core.launcher.Main.main(Main.java:959)

Comment 1 Jane Fang

2007-01-30 17:10:52 EST

Also, if user cancels the logon, connect seems to return CONNECTION_HOST_ERROR at the end, which is not correct.

Comment 2 Eugene Chan

2007-01-30 17:14:33 EST

target 4.4 for now.

Comment 3 Eric Labadie

2007-08-09 16:00:47 EDT

This is required from AC perspective.

Comment 4 Alex Nan

2007-11-30 15:20:46 EST

Fixed.

Comment 5 Paul Slauenwhite

2009-06-30 13:19:47 EDT

As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.