Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 172142

Summary: 'Open Type' does not indicate that it is indexing.
Product: [Eclipse Project] JDT Reporter: Dani Megert <daniel_megert>
Component: UIAssignee: Krzysztof Michalski <krzysztof.michalski>
Status: VERIFIED FIXED QA Contact:
Severity: major    
Priority: P3 CC: markus.kell.r
Version: 3.3   
Target Milestone: 3.3 M6   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 172883    
Attachments:
Description Flags
Proposition of changes none

Description Dani Megert CLA 2007-01-30 06:35:33 EST 
3.3 M4 and I20070123 + plug-in export I20070123-1715.from20070130_1135

'Open Type' does not indicate that it is indexing. It simply shows how much work is done but not what it is doing. This used to work in previous builds, e.g. M4.
Comment 1 Markus Keller CLA 2007-02-01 05:10:54 EST 
Krzysztof, can you please look into this for M5?
Comment 2 Tod Creasey CLA 2007-02-22 12:32:40 EST 
Krzysztof what is the status of this?
Comment 3 Markus Keller CLA 2007-02-26 06:23:56 EST 
Steps in HEAD:

- new workspace
- disable autobuild
- open Progress view and enable "Show sleeping and system operations"
- import org.eclipse.jdt.ui and all required plug-ins as source
- in Package Explorer, select first source folder
- open New Class wizard
- press Supertype > Browse (Alt+e)
- type "A"

=> For a long time, the progress message is just "Searching (0%)". The old Open Type dialog showed a separate progress dialog to indicate indexing progress.

The new way of doing the indexing inside the dialog is superior, since it allows the user to enter a type name immediately after opening the dialog (cf. bug 96077). However, the progress message should still be the same as before while the indexing takes place (since this can be a long running operation in big workspaces, and the user might want to cancel and use other means to open the editor).
Comment 4 Krzysztof Michalski CLA 2007-03-01 05:55:03 EST 
Created attachment 60055 [details]
Proposition of changes

I added necessary parts of code.
Comment 5 Markus Keller CLA 2007-03-01 08:53:31 EST 
Released the patch to HEAD.

The patch just copies TypeSelectionDialog2.ensureConsistency() to FilteredTypesSelectionDialog (with a slight change that revealed bug 176017). This probably also fixes problems with outdated history items.

I've reopened bug 96077 for the extra progress dialog.
Comment 6 Dani Megert CLA 2007-03-20 11:01:36 EDT 
Verified in I20070320-0010.