| Summary: | Improve error reporting when the JVMTI Profiler cannot be launched | ||
|---|---|---|---|
| Product: | z_Archived | Reporter: | Asaf Yaffe <asaf.yaffe> |
| Component: | TPTP | Assignee: | jkubasta |
| Status: | CLOSED WONTFIX | QA Contact: | |
| Severity: | normal | ||
| Priority: | P2 | CC: | analexee, guru.nagarajan, jkubasta, leo_welsch, te |
| Version: | unspecified | Keywords: | plan |
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | closed471 | ||
|
Description
Asaf Yaffe
This defect is needed to be addressed for IPF and X64 where no GA driver is available. Ruslan - please take over this defect to add additional messages. There are following texts reprorted on errors: unable to locate the JVMTI runtime libraries (Agent is simply removed from AC plugin dir to reproduce on win32): ERROR_TI_AGENT_UNAVAILABLE= >>The JVMTI agent {0} is not available. Make sure that the libraries for the agent are available and that it is configured properly.<< timeout issues with AC (when AC is not running): ERROR_TI_AC_UNAVAILABLE= >>Agent Controller is unavailable under port {0}. Make sure that the service is started and the port number is correct under preferences.<< for other errors, e.g. VM initialization error is related with ERROR_TI_AGENT_UNAVAILABLE -> agent is not available the VM initialization error occurs. So we already have these two main errors for 'unavailable' AC and Agent causing the JVMTI Profiler fail to be launched. What detailed text should be assigned for ERROR_TI_AGENT_UNAVAILABLE and ERROR_TI_AC_UNAVAILABLE messages? Suggestion: ERROR_TI_AGENT_UNAVAILABLE= >>The JVMTI agent {0} is not available. Unable to locate the JVMTI runtime libraries. Make sure that the libraries for the agent are properly installed in the <AC HOME>\plugins directory and that it is configured properly.<< timeout issues with AC (when AC is not running): // note: timout is equivalent to unavailability in this case ERROR_TI_AC_UNAVAILABLE=<as is> My suggestion about the text would be:
Make sure that the libraries for the agent are available and that it is configured properly.
===>>
>>Make sure that the libraries for the
agent are properly installed in the <AC HOME>\plugins directory and that it is
configured properly.
<AC HOME> = [... path to the AC HOME-variable]<<
If the AC HOME is not set, then I would bring an extra message.
1) MYYY problem was that I misunderstood the <AC HOME> with the <ECLIPSE HOME> and should be little bit more clear in the Error-messages.
2) Using all the time the same string for the Error-message is OK as long as it is the content is clear for all types or messages. I personally do not understand the meaning of
'Make sure that the libraries for the agent are available'
because from it, would NOT know WHAT to check resp. WHAT to 'make sure'. And if it is only a variable which should be set, then make this clear. IF something else is a prerequisit, then this should be in the Error-message as well.
Lets address this in i4 Alexander, This is assigned to you at this time. This is a candidate for deferral for 4.4+ given where we are in the cycle Deferred to 4.5 Igor, please also take a look on messages related to user notification. They should not contain any internal IDs. moved to future with PMC approval Mass update of P1 enhancements and defects targetted to future to P2. As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. Since this defect is more than 2 years old, it may be no longer relevant. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this defect is resolved as WONTFIX. If this defect is still relevant and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open. As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open. |