Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 171124

Summary:

Find function doesn't work properly in AGR macro editor

Product:

z_Archived

Reporter:

Alex Nan <apnan>

Component:

TPTP

Assignee:

Liz Dancy <lizdancy>

Status:

CLOSED FIXED

QA Contact:

Severity:

major

Priority:

CC:

amehrega, paulslau

Version:

unspecified

Keywords:

plan

Target Milestone:

---

Hardware:

OS:

Windows 2000

Whiteboard:

Attachments:

Description	Flags
Patch that fixes Find problem	none
Second version of the patch	none

Description Alex Nan

2007-01-19 20:34:25 EST

Build ID: TPTP-4.2.2-200701151346

Steps To Reproduce:
1.Generate a macro that creates a Java project
2. Open the macro editor and find for the string "command".
3. Find backward, the backward find will jump to the beginning of the macro. Also according to test case Test.UI.AutoGUIRunner->FindOperation, pressing F7 should trigger the find function but it doesn't.

More information:

Comment 1 amehrega

2007-01-22 10:12:19 EST

F7 shouldn't trigger the find dialog.  Ctrl + F does (Alex: please update the test description).

I have confirmed that there is a problem when finding a string using the backward option.  Re-assigning the defect to Liz.

Comment 2 Alex Nan

2007-01-22 10:31:23 EST

Test case FindOperation updated.

Comment 3 Paul Slauenwhite

2007-01-26 08:20:04 EST

Please provide an estimated sizing for this defect.

Comment 4 Paul Slauenwhite

2007-01-26 08:25:32 EST

Targeting to future since not containable in 4.4.

Comment 5 Paul Slauenwhite

2007-01-26 09:01:22 EST

As discussed on this week's Test Project call (January 22, 2007), the Test Project will focus on existing P1 - P2/Blocker - Major and P1/Normal and test creation/automation defects (omitting defects dependant on outstanding features) in TPTP 4.4.  All other Test Project defects have been targeted to future.

If this defect has been targeted to future and you/originator feel it should be completed in 4.4, please provide the necessary reason as a reply to this comment or a post to the Test Project mailing list (tptp-test-tooling-dev@eclipse.org).  We will collectively triage and assess our resources to determine a case-by-case decision.

Comment 6 Paul Slauenwhite

2007-01-26 09:03:38 EST

Correction:  The Test Project mailing list is tptp-testing-tools-dev@eclipse.org.

Comment 7 Liz Dancy

2007-02-06 13:22:51 EST

Created attachment 58366 [details]
Patch that fixes Find problem

I have attached a patch which solves the problem. This can be reviewed/checked in after the test pass finishes.

Comment 8 amehrega

2007-02-07 14:02:29 EST

According to Paul, HEAD is close until we're done with TP1 (EOD Feb 14th).  Please remind me to review and check-in the patch once HEAD opens again.

Comment 9 Paul Slauenwhite

2007-02-07 14:07:20 EST

(In reply to comment #8)
> According to Paul, HEAD is close until we're done with TP1 (EOD Feb 14th). 
> Please remind me to review and check-in the patch once HEAD opens again.

Please consult the TPTP 4.4 schedule for development and TP dates:

http://www.eclipse.org/tptp/home/project_info/releaseinfo/4.4/schedule.html

Comment 10 amehrega

2007-02-26 11:28:46 EST

Created attachment 59799 [details]
Second version of the patch

I reviewed the patch and made some changes.
There was some repeated code in the first and second block of the find method that I captured under two helper methods.

Thanks Liz for fixing the problem.

Comment 11 Liz Dancy

2007-02-26 16:59:17 EST

Revised patch committed. Closing defect.

Comment 12 Paul Slauenwhite

2007-02-27 07:37:34 EST

Correcting targets.

Comment 13 Liz Dancy

2007-03-12 17:12:22 EDT

Updating hours worked.

Comment 14 Paul Slauenwhite

2007-06-02 14:51:40 EDT

Reporter: Please verify and close in preparation for shutting down the TPTP 4.4 release.  Thanks.

Comment 15 Liz Dancy

2007-06-12 10:55:23 EDT

Verified in TPTP candidate 200706070100.

Comment 16 Liz Dancy

2007-06-12 10:55:30 EDT

Closing