Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 170758

Summary: [CommonNavigator] org.eclipse.ui.navigator.resources should export all packages
Product: [Eclipse Project] Platform Reporter: Markus Keller <markus.kell.r>
Component: UIAssignee: Francis Upton IV <francisu>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: john.arthorne, pwebster
Version: 3.3Flags: pwebster: review+
Target Milestone: 3.4.1   
Hardware: PC   
OS: Windows XP   
Whiteboard: ready
Attachments:
Description Flags
Patch none

Description Markus Keller CLA 2007-01-17 07:13:13 EST 
I20070116-1510

org.eclipse.ui.navigator.resources should export all packages. Please set 'project properties > Plug-in Development > Plug-in Manifest Compiler > Non-exported packages' to Error.

The missing (internal) package is org.eclipse.ui.internal.navigator.workingsets.
Comment 1 Markus Keller CLA 2007-05-09 05:24:44 EDT 
Still an issue in HEAD, should be fixed for 3.3.
Comment 2 Markus Keller CLA 2007-05-29 08:09:36 EDT 
Bug 189448 has added the package, but has not fixed the manifest compiler setting to prevent this from happening in the future.
Comment 3 Francis Upton IV CLA 2008-08-14 05:45:17 EDT 
Created attachment 109969 [details]
Patch

Here is the change for the settings.
Comment 4 Francis Upton IV CLA 2008-08-14 05:46:10 EDT 
Paul can you review this for 3.4.1?
Comment 5 Paul Webster CLA 2008-08-14 09:07:20 EDT 
Works fine for me.
PW
Comment 6 Francis Upton IV CLA 2008-08-14 21:48:11 EDT 
Released to HEAD (35M2) and to R3_4_maintenance for 3.4.1
Comment 7 Francis Upton IV CLA 2008-08-31 23:31:13 EDT 
Verified in M20080827-2000 by looking at the source provided in the kit.
Comment 8 John Arthorne CLA 2009-06-01 09:41:26 EDT 
Removing iplog+ flag, I don't see any evidence of a contribution from a non-committer here.