Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 170721

Summary: Fix JavaDoc on GraphicalEditorWithPalette
Product: [Tools] GEF Reporter: Chris Lee <eclipse>
Component: GEF-Legacy GEF (MVC)Assignee: Anthony Hunter <ahunter.eclipse>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 3.2   
Target Milestone: 3.3.0 (Europa) M6   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Chris Lee CLA 2007-01-16 21:10:12 EST
Build ID: M20060629-1905

Steps To Reproduce:
1. The class GraphicalEditorWithPalette recommends to *not* extend the implementation provided, but rather to copy and paste the class for your own use.
2. I cannot use a copy-paste version of the class because the class Splitter, referenced in createPartControl, is not visible external to GEF


More information:
Comment 1 Randy Hudson CLA 2007-01-29 07:07:06 EST
We should probably just remove the comment that recommends not subclassing. It is not realistic.
Comment 2 Anthony Hunter CLA 2007-03-22 09:59:12 EDT
(In reply to comment #1)
> We should probably just remove the comment that recommends not subclassing. It
> is not realistic.

Agreed, many clients have already extended GraphicalEditorWithPalette.

I have removed the comment.

Comment 3 Randy Hudson CLA 2007-03-22 10:39:07 EDT
Chris, if you are still interested in some kind of custom splitter widget outside of the editor hierarchy, the project whose mission is to provide such widgets is Nebula.  You could look there and even submit our (internal) Splitter class to them as a starting point for some kind of custom widget.
Comment 4 Chris Lee CLA 2007-03-22 13:31:05 EDT
I'm good - we already extend the GraphicalEditorWithPalette; I was just noting that the doc said we weren't supposed to, so I was worried it might change and break our app.