Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 170641

Summary: FilteredItemsSelectionDialog is flashing when typing
Product: [Eclipse Project] JDT Reporter: Martin Aeschlimann <martinae>
Component: UIAssignee: Krzysztof Michalski <krzysztof.michalski>
Status: VERIFIED FIXED QA Contact:
Severity: major    
Priority: P2 CC: Bartosz.Kowalewski, daniel_megert, markus.kell.r, Tod_Creasey
Version: 3.3   
Target Milestone: 3.3 M6   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 172883    

Description Martin Aeschlimann CLA 2007-01-16 10:53:11 EST 
20070116

When typing in the Java open type dialog which is now based on the FilteredItemsSelectionDialog, you see that the entries refresh, even if they don't change.
For example type slowly 'Array'. After every letter, the list refreshes, but most entries are unchanged.
Comment 1 Bartosz Kowalewski CLA 2007-01-26 08:58:55 EST 
A virtual table with a lazy content provider was introduced. The problem is that every refresh() called on the TableViewer with a virtual table causes the list to be cleared. All of the items have to be set once again. 

(refresh on the table viewer causes the internalRefresh(Object element, boolean updateLabels) in the AbstractTableViewer to be invoked; 
this method always passes calls to internalVirtualRefreshAll() which clears everything; that is, invokes the doClearAll())

We're currently trying to make a workaround - all refreshes will be done 'manually', without calling any refresh methods of the viewer. Only standard (automatic) UI updates associated with scrolling, resizing, etc. will be done on the basis of lazy content provider (updateElement()).
Comment 2 Markus Keller CLA 2007-02-01 05:12:13 EST 
This is a major item for M5.
Comment 3 Tod Creasey CLA 2007-02-22 12:31:07 EST 
Krzysztof what is the status of this?
Comment 4 Krzysztof Michalski CLA 2007-02-23 08:15:40 EST 
After our changes inside dialog, i can't reproduce this bug. Everything looks good since N20070223-0010.
Markus, could you look at it?
Comment 5 Markus Keller CLA 2007-02-26 06:45:40 EST 
Looks fine for me in N20070226-0010. Filed bug 175507 for flashing in the Open Resource dialog.
Comment 6 Krzysztof Michalski CLA 2007-02-27 10:11:32 EST 
Bug has been fixed since N20070226-0010.
Comment 7 Dani Megert CLA 2007-03-20 08:12:11 EDT 
Verified in I20070320-0010.