Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 170216

Summary: [Mac] New Launchers use old icon on OS X
Product: [Eclipse Project] Platform Reporter: Kim Horne <eclipse>
Component: UIAssignee: Kim Horne <eclipse>
Status: RESOLVED WORKSFORME QA Contact:
Severity: normal    
Priority: P3 CC: alex.blewitt, bradleyjames, Silenio_Quarti
Version: 3.3   
Target Milestone: 3.4   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:
Attachments:
Description Flags
Dock vs. App none

Description Kim Horne CLA 2007-01-11 09:34:17 EST
In 3.2 we switched to use a really nice looking icon for the dock.  The new launchers have reverted to using the old icon.  I will attach a screenshot showing the doc icon and the app icon side by side - they are not the same.
Comment 1 Kim Horne CLA 2007-01-11 09:34:41 EST
Created attachment 56763 [details]
Dock vs. App
Comment 2 Alex Blewitt CLA 2007-01-11 09:57:54 EST
I reported this one recently ...
Comment 3 Alex Blewitt CLA 2007-01-11 10:00:01 EST
bug 169631

(but you have a nicer screenshot :-)

NB this is configured in the PDE launch; the runtime mac also has smaller fonts:

bug 169632

Both can be fixed by e.g. -Xdock:../Eclipse.app/Resources/Eclipse.icns and -Dorg.eclipse.swt.useSmallFonts or some such (see bug 169631 and bug 169632 for exact deatils)
Comment 4 Andrew Niefer CLA 2007-01-11 11:41:50 EST
We noticed that the good icon is being displayed until the application starts when it changes to the old icon.
It seems the workbench is taking an icon from the platform plugin and using it.  We probably never noticed it before since the launcher was a separate process and the docking bar would show the icon from the launcher process.
Comment 5 Kim Horne CLA 2007-01-11 11:57:06 EST
This is the case.  This should be simply a matter of updating the icons in the platform and SDK to have 64 and 128 pixel versions that look as we expect.

Tod, what is the requirement for Vista icons?  Vista supports icons up to 128px right?
Comment 6 Andrew Niefer CLA 2007-02-19 12:34:38 EST
*** Bug 173764 has been marked as a duplicate of this bug. ***
Comment 7 Andrew Niefer CLA 2007-02-19 12:37:45 EST
The java launcher usually handles the -Xdock:icon properly (and -Xdock:name) properties.  Because we are no longer using the java launcher on mac, we need to handle these ourselves by setting the system properties
APP_ICON_<pid>=...
APP_NAME_<pid>=...

where <pid> is the result of the system call getpid();
Comment 8 Brad Reynolds CLA 2007-02-19 14:07:35 EST
(In reply to comment #5)
> This is the case.  This should be simply a matter of updating the icons in the
> platform and SDK to have 64 and 128 pixel versions that look as we expect.

FYI, I believe I heard in the WWDC keynote that Apple was asking developers to start shipping 256 pixel icons as well but I can't find anything to back that up online.  In the release notes for Tiger[1] Apple refers to 256 pixel support.

[1] http://developer.apple.com/releasenotes/GraphicsImaging/RN-ResolutionIndependentUI/index.html#//apple_ref/doc/uid/TP40001374-DontLinkElementID_9

Comment 9 Andrew Niefer CLA 2007-02-26 14:19:35 EST
The launcher has been fixed and is now setting the APP_ICON_<pid> and APP_NAME_<pid> environment variables.  The icon is staying as the nice one.

Kim, I'm giving this bug back to you in case you want to update the icons in the platform and sdk.
Comment 10 Kim Horne CLA 2007-05-08 11:17:17 EDT
I'm not going to have time to look into this for 3.3.
Comment 11 Kim Horne CLA 2008-05-14 13:45:39 EDT
Our icons are showing up as we expect.  Marking as WORKSFORME.