Bugzilla – Full Text Bug Listing
| Summary: | Launch Configuration Name should not allow '#' | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] PDE | Reporter: | C. Lamont Gilbert <clg-business> | ||||||
| Component: | UI | Assignee: | bartosz michalik <bartosz.michalik> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | minor | ||||||||
| Priority: | P3 | CC: | bartosz.michalik, baumanbr, caniszczyk, mn, sgandon, wassim.melhem | ||||||
| Version: | 3.2.1 | Keywords: | bugday | ||||||
| Target Milestone: | 3.4 M1 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
The exception is coming from Update code. Update needs a URL to save the platform.xml for the launch configuration. We create a new URL with this path calculated from the launch config name. When the name has a ' ' with a #, it drops everything past the #, yielding the wrong locations. To try to create a URL that contains the #, I tried encoding the value before passing it into the URL constructor. The only problem is that Update does not decode the file path, it just uses it as is. Two possible solutions: 1) Get Update to decode the URL before using the path 2) When we calculate the name, make sure there isn't a " #" in the path. If there is, change it to something else let's go with #2 I'd like to contribute to this bug as Bug Day activity ;) You got it :) Feel free to ask for help, should you need it. Created attachment 74844 [details]
first proposal
Bartek, for this bug, we should not touch Update. We should modify the PDE code that creates the platform config location that PDE auto-generates to create a good name that does not contain # Check for references to IPDELauncherConstants.CONFIG_LOCATION in the org.eclipse.pde.ui plug-in. Created attachment 75027 [details]
changes limited to pde.iu
this simply approach replaces '#' with 'h' when building configuration location.
any comments are welcome
Patch released. Thanks Bartek. *** Bug 241162 has been marked as a duplicate of this bug. *** |
When creating an 'Eclipse Application' launch configuration, if you name it "Configuration #2", it will create a configuration area like so ${workspace_loc}/.metadata/.plugins/org.eclipse.pde.core/Configuration #2 This fails I assume because of the space preceeding #2. I am not certain if that is the case, but in any event, if this fails, it should be disallowed by the UI. This is possibly related to bug #162075