| Summary: | [Navigation] Reach End dialog: "don't ask again" checkbox not always present | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Dani Megert <daniel_megert> |
| Component: | Compare | Assignee: | Platform-Compare-Inbox <platform-compare-inbox> |
| Status: | CLOSED WONTFIX | QA Contact: | |
| Severity: | minor | ||
| Priority: | P3 | CC: | Szymon.Brandys, tomasz.zarna |
| Version: | 3.3 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Whiteboard: | stalebug | ||
|
Description
Dani Megert
In some respects, the distinction between Compare and Team is becoming blurred (for instance, if your using the new Java element compare, that is actually provided by Team as well). The preference is a Compare preference because the behavior is implemented in the TextMergeViewer. However, it is only triggered when there is multiple elements being compare and this typically only happens when a repository provider is involved (although you also get the behavior when using Compare with Each Other). One way of addressing your concern would be to prompt to go to the next/previous history entry when the end/beginning is reached (i.e. and have the same prompt with the "don't ask again"). What do you think? What I would expect is that if the preference is set to "Prompt..." I always get the dialog with the checkbox. If "Loop..." is selected then the behavior is already as expected. If "Go to..." is selected then I would either expect a dialog that says "end/start reached" plus an OK button (no other choice). Or (preferred): go to the first/last element in the view. Bug 195495 is related to this as well. Patch 002 attached to bug 195495 fixes this problem. We have to postpone the fix. (In reply to comment #4) > Patch 002 attached to bug 195495 fixes this problem. The patch needs some adjustments, I'll revisit it during 3.5. See also bug 195495. Fixed along with bug 195495. This bug is not fixed: Follow steps from comment 0 (in case it wasn't clear >4. press the next button until you get the dialog meant: click the 'Next Difference' button in the global tool bar (or press Ctrl+.) ==> you get the dialog from picture1 Expected: - out of the box get dialog from picture2 - when changing the compare preference (see bug 195495), honor them Dani, I closed the bug because I thought you referred the "Next Difference" button in the Compare editor. Yes, sorry wasn't too clear here. Any decent fix would involve an API addition or switching to commands and handlers. Since it's to late for such a change I'm postponing the fix to 3.6. Agree. Moving to 3.7. Returning to inbox. No plans to address it in the nearest future. This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug. If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie. |