Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 170168

Summary: [Navigation] Reach End dialog: "don't ask again" checkbox not always present
Product: [Eclipse Project] Platform Reporter: Dani Megert <daniel_megert>
Component: CompareAssignee: Platform-Compare-Inbox <platform-compare-inbox>
Status: CLOSED WONTFIX QA Contact:
Severity: minor    
Priority: P3 CC: Szymon.Brandys, tomasz.zarna
Version: 3.3   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard: stalebug

Description Dani Megert CLA 2007-01-11 02:51:16 EST
I20060110-1800

The Reach End dialog only offers the "don't ask again" checkbox when the compare view has more than one resource. This lead me to the wrong conclusion that this preference is a Team preference.

Test Case:
1. open a CU
2. add some changes in different Java elements and save
3. compare with local history
4. press the next button until you get the dialog
==> checkbox missing
Comment 1 Michael Valenta CLA 2007-01-11 09:00:25 EST
In some respects, the distinction between Compare and Team is becoming blurred (for instance, if your using the new Java element compare, that is actually provided by Team as well). The preference is a Compare preference because the behavior is implemented in the TextMergeViewer. However, it is only triggered when there is multiple elements being compare and this typically only happens when a repository provider is involved (although you also get the behavior when using Compare with Each Other). 

One way of addressing your concern would be to prompt to go to the next/previous history entry when the end/beginning is reached (i.e. and have the same prompt with the "don't ask again"). What do you think?
Comment 2 Dani Megert CLA 2007-01-11 09:16:26 EST
What I would expect is that if the preference is set to "Prompt..." I always get the dialog with the checkbox.

If "Loop..." is selected then the behavior is already as expected.

If "Go to..." is selected then I would either expect a dialog that says "end/start reached" plus an  OK button (no other choice). Or (preferred): go to the first/last element in the view.
Comment 3 Michael Valenta CLA 2007-07-16 10:59:27 EDT
Bug 195495 is related to this as well.
Comment 4 Krzysztof Michalski CLA 2007-09-12 12:17:17 EDT
Patch 002 attached to bug 195495 fixes this problem.
Comment 5 Szymon Brandys CLA 2007-10-23 05:26:04 EDT
We have to postpone the fix.
Comment 6 Tomasz Zarna CLA 2008-04-17 06:08:51 EDT
(In reply to comment #4)
> Patch 002 attached to bug 195495 fixes this problem.

The patch needs some adjustments, I'll revisit it during 3.5.

Comment 7 Szymon Brandys CLA 2009-03-06 05:56:15 EST
See also bug 195495.
Comment 8 Pawel Pogorzelski CLA 2009-03-17 07:48:15 EDT
Fixed along with bug 195495.
Comment 9 Dani Megert CLA 2009-04-29 04:18:36 EDT
This bug is not fixed:

Follow steps from comment 0 (in case it wasn't clear 
>4. press the next button until you get the dialog
meant: click the 'Next Difference' button in the global tool bar (or press Ctrl+.)

==> you get the dialog from picture1

Expected:
- out of the box get dialog from picture2
- when changing the compare preference (see bug 195495), honor them
Comment 10 Pawel Pogorzelski CLA 2009-04-29 08:06:44 EDT
Dani, I closed the bug because I thought you referred the "Next Difference" button in the Compare editor.
Comment 11 Dani Megert CLA 2009-04-29 08:13:08 EDT
Yes, sorry wasn't too clear here.
Comment 12 Pawel Pogorzelski CLA 2009-04-30 01:20:36 EDT
Any decent fix would involve an API addition or switching to commands and handlers. Since it's to late for such a change I'm postponing the fix to 3.6.
Comment 13 Dani Megert CLA 2009-04-30 02:23:36 EDT
Agree.
Comment 14 Pawel Pogorzelski CLA 2010-04-19 07:21:15 EDT
Moving to 3.7.
Comment 15 Pawel Pogorzelski CLA 2010-07-19 09:02:28 EDT
Returning to inbox. No plans to address it in the nearest future.
Comment 16 Eclipse Webmaster CLA 2019-09-06 15:35:38 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
Comment 17 Eclipse Genie CLA 2021-09-24 07:43:11 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.