Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 169967

Summary:	[Workbench] No possibility to update the value of "fIsEmpty" field of ElementTreeSelectionDialog
Product:	[Eclipse Project] Platform	Reporter:	Martin Herbort <martinherbort>
Component:	UI	Assignee:	Platform UI Triaged <platform-ui-triaged>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	normal
Priority:	P5	CC:	cvogt
Version:	3.3	Keywords:	helpwanted
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:	stalebug

Description Martin Herbort

2007-01-09 08:45:17 EST

Build ID: I20061102-1715

Steps To Reproduce:
1. Create an ElementTreeSelectionDialog.
2. Assign a non-Null but empty semantic model as input.
3. Semantically add a element to the semantic model.
4. Then the dialog will show the semantic element but you won't be able to select it and hit OK.


More information:
The private boolean field "fIsEmpty" is set only in the open(). But it must be possible to somehow update its value (the OK status respectively) upon modifications of the semantic model.

Proposal 1:
Change updateOKStatus() to explicitly look for model changes.

Proposal 2:
Declare fIsEmpty as *protected* boolean fIsEmpty.

Comment 1 Christian Vogt

2008-04-10 18:30:46 EDT

I'm running into the same issue when the dialog is opened with no entries. My dialog is dynamic in that users can add entries after the dialog is opened. The fact that there is no way to reset the value of "fIsEmpty" is a problem. Sure there are ways to re-enable the widgets, or remove the error status message, but there is no way to reset the value of "fCurrStatus" if "fIsEmpty" had been set to true, and certain functionality depends on the state of "fCurrStatus".

Comment 2 Eclipse Webmaster

2019-09-06 16:13:10 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

Comment 3 Eclipse Genie

2021-10-22 15:40:31 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.