Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 169900

Summary: Build scan limitations.
Product: z_Archived Reporter: Paul Slauenwhite <paulslau>
Component: TPTPAssignee: Samuel Wu <samwu>
Status: CLOSED WONTFIX QA Contact:
Severity: normal    
Priority: P2 CC: jcayne, kathy
Version: unspecifiedKeywords: plan
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:

Description Paul Slauenwhite CLA 2007-01-08 17:20:34 EST
Build scans do not include all plug-ins in CVS. 

Since all TPTP plug-ins are in the public domain via CVS, they should be all included in the following build scans (including the test-results module in CVS (http://dev.eclipse.org/viewcvs/index.cgi/test-results/?cvsroot=TPTP_Project):

-Incorrect copyright year.
-Missing copyright statement.

Also, we need to be scanning all of the TPTP plug-ins (including the test-results module in CVS (http://dev.eclipse.org/viewcvs/index.cgi/test-results/?cvsroot=TPTP_Project) for IP (e.g. IBM Confidential).
Comment 1 Paul Slauenwhite CLA 2007-01-17 11:03:19 EST
These scans should also include all Technology Preview plug-ins.
Comment 2 Paul Slauenwhite CLA 2007-01-17 11:07:36 EST
(In reply to comment #0)

Also, this defect should also include the following scans:

All copyright patterns  
Classes using non-TPTP internal packages
Comparing version numbers with previous release
Modules that have changed since the last tagged build

Comment 3 Paul Slauenwhite CLA 2007-01-17 11:22:11 EST
The current scan for comparing version numbers with previous releases determines problematic versions based on the last full release.  In the current reports, if the current version of a plugin is greater than the previous version, the current version is not reported as problematic.  That is, plugins versioned in a maintenance release that GAed during the full release (e.g. parallel development) that do contained changes specific to the full release are not reported as problematic.  By way of illustration, in the Test project we have several plugins (e.g. org.eclipse.hyades.test.tools.core) that were changed in both 4.2.1 and 4.3.  However, their version number was updated in 4.2.1 and they do not appear as problematic in 4.3.0 since their current version number is greater than their previous version number.  I think we need to track the version numbers relative to the last maintenance release rather than the last full release.

Furthermore, the current scan for comparing version numbers with previous releases does not identify defect (requires third digit version updates) vs feature (requires second digit version updates) updates to plugins.  Since we can find the list of fixed defects/features for a release from Bugzilla, we should be able to track which plugins/features have been updated for these defects/features.

As such, we should be able to do automatic/batch updates of plugin/feature version numbers based on the results of the build report.  This could be done at the end of a maintenance/full release.
Comment 4 Paul Slauenwhite CLA 2007-01-18 09:06:06 EST
Two more useful features:

1) Email notification to componet/project leads when an action is required  (e.g. update version/copyright) or violation is detected (e.g. internal API usage, missing copyright) to expedite the resolution.

2) Automatic copyright year updates.  Since the scanning script knows when the copyright year is missing/incorrect, it can automatically fix the mistake and check the file back into CVS. Although this may encourage laziness on the part of the committer/contributor, it is much more efficient and productive (especially when one committer does a mass update).
Comment 5 Paul Slauenwhite CLA 2007-01-18 09:07:08 EST
Increasing severity since these are issues that should be evaluated to streamline our release engineering processes.
Comment 6 jkubasta CLA 2007-04-20 08:31:36 EDT
Is this containable in 4.4?
Comment 7 jkubasta CLA 2008-05-23 08:52:59 EDT
Deferral to future with PMC approval
Comment 8 Kathy Chan CLA 2009-02-23 13:40:13 EST
Mass update of P1 enhancements and defects targetted to future to P2.
Comment 9 Paul Slauenwhite CLA 2009-06-30 07:00:06 EDT
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. Since this defect is more than 2 years old, it may be no longer relevant. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this defect is resolved as WONTFIX. If this defect is still relevant and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.
Comment 10 Joshua Bowles CLA 2009-06-30 09:52:29 EDT
This is still an issue but hasn't been worked on since a work around is in place.  A fix will be done as part of a series of build improvements for 4.6.1.
Comment 11 Joshua Bowles CLA 2009-06-30 10:00:44 EDT
(In reply to comment #10)
> This is still an issue but hasn't been worked on since a work around is in
> place.  A fix will be done as part of a series of build improvements for 4.6.1.

Sorry, wrong bug commented on. 

Comment 12 Paul Slauenwhite CLA 2009-07-02 15:15:35 EDT
Reopening since still relevant.
Comment 13 Paul Slauenwhite CLA 2009-09-24 14:22:35 EDT
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. Since this defect is more than 2 years old, it may be no longer relevant. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this defect is resolved as WONTFIX. If this defect is still relevant and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.
Comment 14 Sean Lamers CLA 2009-09-24 14:40:57 EDT
Still relevant - reopened.
Comment 15 Joel Cayne CLA 2009-12-21 15:35:25 EST
Targeting to 4.7.0.
Comment 16 Kathy Chan CLA 2010-05-25 14:26:32 EDT
Deferring to TPTP 4.7.1.
Comment 17 Kathy Chan CLA 2010-09-09 13:15:38 EDT
Deferring to TPTP 4.7.2.
Comment 18 Kathy Chan CLA 2010-09-15 14:46:05 EDT
Re-assigning to Sam.
Comment 19 Joel Cayne CLA 2010-11-25 15:36:07 EST
The current tools check copyright, version, module changes and internal use. The project leads and release team usually check the report prior to a release to update versions and copyrights.
No plan to fix.
Comment 20 Paul Slauenwhite CLA 2010-11-25 16:03:49 EST
Closing.