Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 169730

Summary: Dialog fonts should be used in TPTP preference pages
Product: z_Archived Reporter: David Whiteman <dlwhiteman>
Component: TPTPAssignee: Paul Klicnik <pklicnik>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P1 CC: ewchan, jkubasta, paulslau
Version: unspecifiedKeywords: plan
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard: closed460
Bug Depends on: 181184    
Bug Blocks:    
Attachments:
Description Flags
patch
none
patch for test plug-ins none

Description David Whiteman CLA 2007-01-05 17:12:49 EST 
Build ID: M20060921-0945

Steps To Reproduce:
1. go to Window > Preferences in eclipse
2. type "font" in the filter text field
3. select "Colors and Fonts" in the tree
4. type "dialog" in the filter text field on the right side
5. select "Dialog Font"
6. click Change and choose a different dialog font size, such as 16
7. click OK to save the preferences
8. go back to the preferences and select preference groups such as "Ant" and "Help", and notice the pages all use the new dialog font size
9. Now go to any of the preference pages under "Analysis", "Profiling", or "Test".  Notice that most or all of the fonts are not using the Dialog font


More information:
Dialog font is the expected font for Eclipse preference pages.  Notice that preference pages originating from TPTP in the standard TPTP workspace are the only ones that don't follow this convention.

The solution is easy.  At the end of the createControl() method, call this:

Dialog.applyDialogFont(topControl);

where "topControl" is the top most control on the preference page.  This method will recursively ensure that every child of that control also uses the Dialog font.
Comment 1 Eugene Chan CLA 2007-02-05 12:18:23 EST 
cannot be contained in 4.4i1
Comment 2 jkubasta CLA 2007-04-03 21:25:02 EDT 
Paul, please resolve this defect and review the code changes with Eugene.
Comment 3 Paul Klicnik CLA 2007-04-04 15:03:00 EDT 
Created attachment 62968 [details]
patch

Patch which adjusts the font in the preferences pages accordingly

Searched the CVS for plugins that contribute preference pages ('org.eclipse.ui.preferencePages' extension point). Added the code suggested in comment 1 to all preference pages ( Dialog.applyDialogFont(topControl); )
Comment 4 Eugene Chan CLA 2007-04-05 00:23:43 EDT 
Reviewed, tested and patch is checked in. Except the changes for the following plug-ins that I don't have access to them.

org.eclipse.hyades.test.tools.ui
org.eclipse.hyades.test.ui
org.eclipse.hyades.test.ui.extensions
org.eclipse.tptp.test.samples.

Paul S, would you please help commit the changes? I will attach an update patch apply to the plug-ins listed above.
Comment 5 Eugene Chan CLA 2007-04-05 00:24:43 EDT 
Created attachment 63002 [details]
patch for test plug-ins

Paul S. Would you please apply the following patch to HEAD(4.4i3)?
Comment 6 Paul Slauenwhite CLA 2007-04-05 08:08:07 EDT 
(In reply to comment #5)
> Created an attachment (id=63002) [details]
> patch for test plug-ins
> 
> Paul S. Would you please apply the following patch to HEAD(4.4i3)?
> 

Thanks Eugene.  I will review and commit this patch under https://bugs.eclipse.org/bugs/show_bug.cgi?id=181184.
Comment 7 Eugene Chan CLA 2007-04-05 10:43:53 EDT 
Thanks Paul S and Paul K =)

Close this bug as bug 181184 is also resolved.
Comment 8 Paul Slauenwhite CLA 2009-06-30 13:50:15 EDT 
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.
Comment 9 Paul Slauenwhite CLA 2009-06-30 14:15:53 EDT 
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.