Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 168720

Summary:	[Progress] No prompting on errors from jobs
Product:	[Eclipse Project] Platform	Reporter:	Dani Megert <daniel_megert>
Component:	UI	Assignee:	Szymon Brandys <Szymon.Brandys>
Status:	VERIFIED FIXED	QA Contact:
Severity:	critical
Priority:	P1	CC:	david_williams, john.arthorne, markus.kell.r, Michael.Valenta, Tod_Creasey, tom.seidel, wayne.beaton
Version:	3.3
Target Milestone:	3.3 M5
Hardware:	PC
OS:	Windows XP
Whiteboard:
Bug Depends on:
Bug Blocks:	169504

Description Dani Megert

2006-12-20 11:29:36 EST

3.3 M4

1. do some major work in a CVS shared project to which you DO NOT have commit
   rights (but you forgot this because you have commit rights on many projects)
2. select the project and then Team > Commit... to commit the project
   ==> no dialog, no indication in progress area
   ==> you think it worked just fine
3. delete the workspace since this was just some special work

OBSERVE: all work from step 1 is lost.

When repeating these steps I found out that an error is silently written to .log

Comment 1 Dani Megert

2006-12-20 11:32:03 EST

NOTE: only showing an indication in the progress area wouldn't be good enough: there has to be a dialog in such a scenario.

Comment 2 Michael Valenta

2006-12-20 12:25:00 EST

This applies to all background jobs. The problems was introduced by the fix to bug  166800 which removed the call to the error manager when a status severity was ERROR. I have reverted the ProgressManager to the pre-166800 state in HEAD. As part of that reverse, the call to the status manager was removed. I'll leave this open in case work needs to be done to properly integrate the status manager into the progress manager.

Comment 3 John Arthorne

2006-12-20 12:27:15 EST

Note this can easily be tested using the Job Factory view in org.eclipse.ui.examples.jobs. Just check off the "Fail" checkbox and schedule a job.

Comment 4 John Arthorne

2006-12-20 13:01:58 EST

Accidentally changed priority...

Comment 5 John Arthorne

2006-12-20 16:16:23 EST

A patched version of the 3.3 M4 jar can be found here:

http://dev.eclipse.org/viewcvs/index.cgi/platform-ui-home/patch/168720/org.eclipse.ui.workbench_3.3.0.I20061214-1401patch.jar?revision=1.1

Comment 6 Tod Creasey

2007-01-02 08:30:21 EST

Szymon this is due to the error handling changes.

Comment 7 Szymon Brandys

2007-01-03 08:45:06 EST

(In reply to comment #6)
> Szymon this is due to the error handling changes.
> 

Yes, you are right. Thanks John for the patch.

The problem is that the error handling facility 
doesn't show an error dialog, even if the handling hint is set to SHOW.
When I add the dialog, I will apply my changes again and it should work.

Comment 8 Michael Valenta

2007-01-03 09:56:38 EST

John just reminded me that the Jobs error dialog has a bunch of special handling. For instance, if the dialog is open and additional errors occur, the dialog will add those errors to the list of errors being displayed in order to avoid multiple error prompts. Also, the Jobs error dialog shows a button that performs the job's action if there is one. For instance, for CVS errors, a button with Show CVS Console is added to the dialog to lead the user to the console which may have additional information. any replacement error dialog should have these features.

Comment 9 Szymon Brandys

2007-01-09 11:58:10 EST

It is rolled back as Michael mentioned in comment #2.
I will raise another bug for hooking the error handling into job stuff.

Comment 10 Paul Webster

2007-01-25 14:40:06 EST

*** Bug 171676 has been marked as a duplicate of this bug. ***

Comment 11 Tim deBoer

2007-02-20 23:50:28 EST

*** Bug 174913 has been marked as a duplicate of this bug. ***