Bugzilla – Full Text Bug Listing
| Summary: | Info: "Error occurred while constructing search page for https://www.limewire.org/jira [jira]" in org.eclipse.mylar.core | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Steffen Pingel <steffen.pingel> | ||||||||
| Component: | Mylyn | Assignee: | Steffen Pingel <steffen.pingel> | ||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||
| Severity: | minor | ||||||||||
| Priority: | P3 | CC: | ekuleshov | ||||||||
| Version: | unspecified | Keywords: | helpwanted | ||||||||
| Target Milestone: | 1.0.1 | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Steffen Pingel
Created attachment 55834 [details]
Screenshot of search dialog
Yes, the dialog is currently fragile to a connector failing to load it (bug 165733). Marking helpwanted for now, see "Support Expectations" at: http://www.eclipse.org/mylar/users.php Moving the setControl() call doesn't work. Unfortunately there doesn't seem to be an easy fix for the layout corruption. I wonder if we can wrap the whole JIRA page into try catch block for now and set control to some dummy panel if it throw an exception I think we would need to dispose all controls that have been created up to the point where the exception is raised, (i.e. iterate over all children of parent). Adding a dummy control then and disabling the Search button should work. Don't think disposing is needed, because those controls will be disposed on regular page disposal anyways. Created attachment 55934 [details]
Patch that disposes controls
Possibly not the cleanest approach but it might be good enough as a workaround for now.
Created attachment 55935 [details]
mylar/context/zip
Patch applied and verified, nice work Steffen. I tested by killing my connection during a settings update, and the result was a nicely formatted error link, with all of the other pages rendering correctly. So as far as my testing checked, you have also resolved bug 165733 with this fix. *** Bug 165733 has been marked as a duplicate of this bug. *** The problem with the patch is that connectors need to invoke setControl() before the exception occurs otherwise the widget can not be disposed. I was thinking of adding a another Composite and use that as the parent widget that is passed to searchPage.createControl(). I could not get it to layout correctly on the first attempt but I think we should fix that for the next milestone. The Eclipse SearchDialog class uses such a wrapper Composite to make the dialog robust against failures of search pages. Good idea. I suggest reopening bug 165733 for that, as it is already assigned to you. But yes, let's hold off until post 1.0.1 for that change. |