Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 167900

Summary: Caption cut off in "Import Symptom Database" window
Product: z_Archived Reporter: Peter Kim <petekim>
Component: TPTP.monitoringAssignee: Yasuhisa Gotoh <gotohy>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P1 CC: gotohy, zung
Version: unspecifiedKeywords: plan
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard: closed460
Attachments:
Description Flags
Screenshot
none
Temporary patch for 167900
none
Patch for VScroll bar on ImportSymptomDBPage2 none

Description Peter Kim CLA 2006-12-13 13:51:48 EST
Hardware Environment:

Software Environment:

Build:
SymptomEditor.win32.win32.x86-TPTP-4.4.0-200612131105

Steps to Reproduce:
1. Import a SDB

Actual Results:
In the window, notice that the caption is cut off

Expected Results:
Message should not be cut off.

Additional Information:
See attached screenshot
Comment 1 Peter Kim CLA 2006-12-13 13:52:03 EST
Created attachment 55601 [details]
Screenshot
Comment 2 Alex Nan CLA 2007-01-12 20:51:41 EST
Rough estimate: 8h.
Comment 3 Dave Smith CLA 2007-02-06 14:46:43 EST
Targetting to iteration 3 and increasing priority to indicate it is planned for
4.4.
Comment 4 Yasuhisa Gotoh CLA 2007-04-20 05:41:26 EDT
This problem occurs when the screen size of the Windows are relatively smaller (such as 800x600 in size) than the size (height) of the Import Symptom Catalog File Wizard dialog.

The lower blank area of the dialog is reserved for the progress monitor and the area is partially hiding the "Open editor after import" check box due to the limited height of the Wizard Dialog.

The symptom import operation is now performed in the background (bugzilla 137186) so that the progress monitor in the Wizard dialog can be removed. This will prevent the caption cut off.
Comment 5 Yasuhisa Gotoh CLA 2007-04-20 09:12:13 EDT
There are two ways to show the Import Symptom Catalog Wizard dialog as follows.

1. Select File->Import... menu. From the Import dialog, choose Profiling and Logging->Symptom Catalog File and click Next button.

2. From the Log Navigator view, right click the tree node and select Import Symptom Catalog menu.

I was able to remove the progress monitor only for the No. 2 case with the attached patch, but it did not work for the No. 1 case.

There would need more investigation for the No.1 case...
Comment 6 Yasuhisa Gotoh CLA 2007-04-20 09:14:38 EDT
Created attachment 64433 [details]
Temporary patch for 167900
Comment 7 Yasuhisa Gotoh CLA 2007-04-21 01:08:26 EDT
Found a relating bug 19462 regarding org.eclipse.jface.wizard.WizardDialog.

It appears that we cannot omit the blank area which is reserved for the progress monitor even when we set the setNeedsProgressMonitor() to false with the latest jface code...

Alex, now I have no idea how to fix this defect.  Can we describe the minimum screen size requirement in the documentation to avoid the caption cut off?
Comment 8 Alex Nan CLA 2007-04-23 13:19:13 EDT
We could place the content of the page into a scrolled composite, so at least we get a vertical scrool bar in the case were the content doesn't fit.
Comment 9 Yasuhisa Gotoh CLA 2007-04-23 22:28:38 EDT
Thank you for the comment, Alex.  I have added a vertical scroll bar to be shown when the composite area of ImportSymptomDBPage2 is small.  Please review the new patch being attached.
Comment 10 Yasuhisa Gotoh CLA 2007-04-23 22:32:25 EDT
Created attachment 64671 [details]
Patch for VScroll bar on ImportSymptomDBPage2
Comment 11 Yasuhisa Gotoh CLA 2007-04-25 04:48:41 EDT
By the way, please assign this bug to me (as it is already assigned). :-)
Comment 12 Alex Nan CLA 2007-04-25 11:35:44 EDT
I have verified the patch, please mark the defect as fixed.
Comment 13 Yasuhisa Gotoh CLA 2007-04-26 07:02:48 EDT
COnfirmed that the patch has been checked in CVS.
Comment 14 Paul Slauenwhite CLA 2009-06-30 10:26:08 EDT
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since the originator of this enhancement/defect has an inactive Bugzilla account and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.