| Summary: | Bugzilla task viewer improperly wraps long strings | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Ian Whalley <inw-eclipse> | ||||||
| Component: | Mylyn | Assignee: | Mylyn Inbox <mylyn-inbox> | ||||||
| Status: | RESOLVED WORKSFORME | QA Contact: | |||||||
| Severity: | trivial | ||||||||
| Priority: | P3 | CC: | eclipse, robert.elves, steffen.pingel | ||||||
| Version: | unspecified | ||||||||
| Target Milestone: | --- | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Ian Whalley
Indeed, the premature wrapping occurs in the description above. Yes, this is a known problem. My last attempt to resolve this resulted in excess space below each comment (reducing density, counter to our goal). It was a tricky reflow problem stemming from the use of text viewers I believe. It has since been relatively low priority. You could vote for bug#142084. *** This bug has been marked as a duplicate of bug 142084 *** Didn't notice the duplicate, sorry. Have voted, although it's not a huge thing. No worries Ian. If after more use it is still bothering you, please feel free to comment/vote on it. Some times the squeaky wheel gets the grease. ;) bug 142084 is resolved now, but this behaviour remains in Mylyn 2.2. Reopening. (In reply to comment #5) > bug 142084 is resolved now, but this behaviour remains in Mylyn 2.2. > Reopening. > What version of Bugzilla did you use? I suppose that you use a version <= 2.18.6 ant then I think that this is related to bug#197539 comment#12. If so that should be fixed. (In reply to comment #6) >>bug 142084 is resolved now, but this behaviour remains in Mylyn 2.2. >>Reopening. >What version of Bugzilla did you use? 2.20.1, so if I understand bug #197539 correctly, it is not relevant. (In reply to comment #7) > (In reply to comment #6) > >>bug 142084 is resolved now, but this behaviour remains in Mylyn 2.2. > >>Reopening. > >What version of Bugzilla did you use? > > 2.20.1, so if I understand bug #197539 correctly, it is not relevant. This has an other reason. It looks like the problem in TaskEditorCommentPart. But I don't know where exactly. It can be an text warping problem or that an control has the wrong size. Do we handle this in this bug or should we create a new one? Frank, is there a sample bug report that I open in Mylyn to reproduce the problem? (In reply to comment #9) > Frank, is there a sample bug report that I open in Mylyn to reproduce the > problem? > I think create a Task for product: Mylyn Component: Task and your description is OK. Does this mean the bug is fixed in cvs and can be marked resolved? Created attachment 104549 [details]
patch
I think that his small pach fix the problem.
Created attachment 104551 [details]
mylyn/context/zip
When I look at the description of this bug I can not see the error. Frank, your patch will not work well if the editor is resized (made less wide) after the comment widget is created. Test: directory1/directory2/directory3/directory4/directory5/directory6/directory7/directory8/com/corp/prod/comp/package1/package2/SourceFileName.java I think I am still missing the problem here? The rendering of comment 14 and the description looks good to me on the latest Mylyn. (In reply to comment #14) > When I look at the description of this bug I can not see the error. Frank, your > patch will not work well if the editor is resized (made less wide) after the > comment widget is created. > Sorry but I think my patch is OK because if you resize the editor all components keep there size. This means that you have a bigger part to scroll. (In reply to comment #16) > > Sorry but I think my patch is OK because if you resize the editor all > components keep there size. This means that you have a bigger part to scroll. > If you do an manual refresh of the editor after an resize you get all the controls build new and the you have the expected size. Mik explained the problem which I now see if I look at the last few lines of the description: Bugzilla adds extra line breaks. In a sense this is not related to having long filenames in the comment (although that might trigger it). This bug needs to be fixed in the Bugzilla SAX parser. It needs to correctly strip out white spaces and new from description and comments (bug 235462). Frank: The fact that comments and descriptions are restricted to a fixed with is intentional and I would like to keep the current behavior. Stale. Text in the task editor task editor now fills the available horizontal width. |