Bugzilla – Full Text Bug Listing
| Summary: | Enhance Thread Statistics View | ||
|---|---|---|---|
| Product: | z_Archived | Reporter: | Guru Nagarajan <guru.nagarajan> |
| Component: | TPTP | Assignee: | Guru Nagarajan <guru.nagarajan> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P1 | CC: | asaf.yaffe, ewchan, ruslan.scherbakov, slavescu, vitaly.a.provodin |
| Version: | unspecified | Keywords: | plan |
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| URL: | http://www.eclipse.org/tptp/groups/Architecture/documents/features/hf_167609.htm | ||
| Whiteboard: | closed460 | ||
| Bug Depends on: | 170207 | ||
| Bug Blocks: | |||
| Attachments: | |||
|
Description
Guru Nagarajan
CHanging component to Trace.UI JVMTI 4.4 ENh I recommend this to be converted to an enhancement and we should use separate bug reports for the actually implementation. Created attachment 57785 [details]
Thread Analysis Enhancements for TPTP 4.4 presentation
cc added Created attachment 57787 [details]
Thread Analysis Enhancements doc - use cases and design of views
Deferred to i2. Created attachment 58675 [details]
Initial impl of enhanced thread views
Ruslan can you create a Patch and attach to the bugzilla. This will make it easier for Eugene to apply and commit. Created attachment 58754 [details]
Thread views impl
(In reply to comment #10) > Created an attachment (id=58754) [details] > Thread views impl > Ruslan, this is not a valid patch format. Please refer to the following link on how to create a patch file from your workspace: http://help.eclipse.org/help32/index.jsp?topic=/org.eclipse.platform.doc.user/tasks/tasks-68c.htm Created attachment 58831 [details]
Patch created by Eclipse-CVS
Options used:
Diff output: Unified
Patch root: project
previously I used wincvs/cygwin,
now I switched source control to Eclipse-CVS
Patch submitted, and updated copyrights' year range to 2007. However, I notice the follow issues in the patched code. - Call stack and Thread States in action set do not contain any icon file. - There are two Trace association with Execution Time analysis. Please see Windows > Preferences > Profiling and Logging > Trace Association Thanks Eugene. Created attachment 58964 [details]
Patch with latest changes + icons
Created attachment 58965 [details]
The same patch without icons
Created attachment 58966 [details]
Archived icons attached
The patch with binary files (icons) may fail to apply so I have additionaly attached icons for views action.
Note, these ones are initial variants of icons. I do not have appropriate image editor in order to set transparent index. These icons can be edited and replaced in the future.
Ruslan, I see the following problem after applying the patches. 1. TASK_CONNECTING_TO_AGENT is missing in NLS message (show in progress view) 2. Icons are of white background, please use the grey tone as in other icons. 3. Following error is thrown when launch with TI. org.eclipse.tptp.platform.execution.exceptions.TimeoutException: Launching Process command timed out. at org.eclipse.tptp.platform.execution.client.core.internal.AgentController.queryAgentByProcessID(AgentController.java:470) at org.eclipse.tptp.platform.execution.client.core.internal.AgentController.getAgent(AgentController.java:837) at org.eclipse.tptp.platform.jvmti.client.internal.launcher.TIDelegateHelper.locateTIAgent(TIDelegateHelper.java:517) at org.eclipse.tptp.platform.jvmti.client.internal.launcher.TIDelegateHelper.attachToAgent(TIDelegateHelper.java:418) at org.eclipse.tptp.platform.jvmti.client.internal.launcher.TIDelegateHelper.attachToAgent(TIDelegateHelper.java:386) at org.eclipse.tptp.platform.jvmti.client.internal.launcher.TIDelegateHelper.access$0(TIDelegateHelper.java:384) at org.eclipse.tptp.platform.jvmti.client.internal.launcher.TIDelegateHelper$2.processLaunched(TIDelegateHelper.java:298) at org.eclipse.tptp.platform.execution.client.core.internal.ProcessImpl$ProcessCommandHandler.processStarted(ProcessImpl.java:896) at org.eclipse.tptp.platform.execution.client.core.internal.ProcessImpl$ProcessCommandHandler.incomingCommand(ProcessImpl.java:843) at org.eclipse.tptp.platform.execution.client.core.internal.ConnectionImpl.handleACCommands(ConnectionImpl.java:244) at org.eclipse.tptp.platform.execution.client.core.internal.ConnectionImpl.access$4(ConnectionImpl.java:233) at org.eclipse.tptp.platform.execution.client.core.internal.ConnectionImpl$1.incomingCommand(ConnectionImpl.java:169) at org.eclipse.tptp.platform.execution.client.core.internal.ConnectionImpl.processControlMessage(ConnectionImpl.java:670) at org.eclipse.tptp.platform.execution.client.core.internal.ConnectionImpl$SocketReaderThread.run(ConnectionImpl.java:773) java.lang.NullPointerException at org.eclipse.tptp.platform.execution.client.core.internal.AgentController.queryAgentByProcessID(AgentController.java:484) at org.eclipse.tptp.platform.execution.client.core.internal.AgentController.getAgent(AgentController.java:837) at org.eclipse.tptp.platform.jvmti.client.internal.launcher.TIDelegateHelper.locateTIAgent(TIDelegateHelper.java:517) at org.eclipse.tptp.platform.jvmti.client.internal.launcher.TIDelegateHelper.attachToAgent(TIDelegateHelper.java:418) at org.eclipse.tptp.platform.jvmti.client.internal.launcher.TIDelegateHelper.attachToAgent(TIDelegateHelper.java:386) at org.eclipse.tptp.platform.jvmti.client.internal.launcher.TIDelegateHelper.access$0(TIDelegateHelper.java:384) at org.eclipse.tptp.platform.jvmti.client.internal.launcher.TIDelegateHelper$2.processLaunched(TIDelegateHelper.java:298) at org.eclipse.tptp.platform.execution.client.core.internal.ProcessImpl$ProcessCommandHandler.processStarted(ProcessImpl.java:896) at org.eclipse.tptp.platform.execution.client.core.internal.ProcessImpl$ProcessCommandHandler.incomingCommand(ProcessImpl.java:843) at org.eclipse.tptp.platform.execution.client.core.internal.ConnectionImpl.handleACCommands(ConnectionImpl.java:244) at org.eclipse.tptp.platform.execution.client.core.internal.ConnectionImpl.access$4(ConnectionImpl.java:233) at org.eclipse.tptp.platform.execution.client.core.internal.ConnectionImpl$1.incomingCommand(ConnectionImpl.java:169) at org.eclipse.tptp.platform.execution.client.core.internal.ConnectionImpl.processControlMessage(ConnectionImpl.java:670) at org.eclipse.tptp.platform.execution.client.core.internal.ConnectionImpl$SocketReaderThread.run(ConnectionImpl.java:773) Patches checked in. Eugene, The stack trace you see is due to a patch commited by a the AC team. I have just fixed that on my machine and will check in the fix. Thanks again Created attachment 59900 [details]
patch 200702280000 - accumulated changes
Created attachment 59901 [details]
binary icons for previous patch 200702280000
patch attached in comment #20 and #21 are checked in with modification in copyright (year) statement of some classes. Created attachment 60096 [details]
3 Mar patch - latest changes
Eugene, please apply this patch to CVS
(In reply to comment #23) > Created an attachment (id=60096) [details] > 3 Mar patch - latest changes > > Eugene, please apply this patch to CVS > Patch submitted. Ruslan - this enhancement is considered complete. For additional issues - lets open a bugzilla and track them As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open. |