Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 167016

Summary: Update Manager keeps trying to update Eclipse
Product: [Eclipse Project] Platform Reporter: Jorge Santos <jorge.jsf>
Component: Update (deprecated - use Eclipse>Equinox>p2)Assignee: Branko Tripkovic <btripkov>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: alexander.portnov, codex69, david, davidcorley, dj.houghton, ehrann.mehdan, greg.allen, gwbeeler, jaapbeetstra, jbammi, jense, jling, john, johndhutcheson, jon, kellyfj, kidd.cs, klaus.hammer, larsforeclipse, Mike_Wilson, mvitorovic, nahor+bugeclipse, p.starostka, rdc, test, tim, twj
Version: 3.2.1   
Target Milestone: 3.2.2   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
patch
none
new patch none

Description Jorge Santos CLA 2006-12-06 19:33:45 EST
The Update Manager keeps finding and (apparently successfully) installing Eclipse Project SDK 3.2.1.r321_v20060801-tQ1w49KnTArT0FZ, asking for a restart and finding it again, etc. ad nauseam.

Do take the string after the _v with a grain of salt since I couldn't find anywhere to copy & paste it from.  Are there any logs for this kind of stuff?
Comment 1 DJ Houghton CLA 2006-12-07 07:31:28 EST
*** Bug 167017 has been marked as a duplicate of this bug. ***
Comment 2 Dejan Glozic CLA 2006-12-07 07:36:36 EST
DJ, Branko, do you have any idea off the top of your head why is UM thinking that the version on the update site is newer than the one installed? 
Comment 3 DJ Houghton CLA 2006-12-07 09:23:48 EST
It looks like there are currently problems with the digest.zip on the eclipse.org update site so perhaps that is related? It is being updated as we speak so I will try and reproduce this problem in a little while.
Comment 4 DJ Houghton CLA 2006-12-07 11:07:53 EST
I am able to reproduce this problem with the new digest so that was not related.
Comment 5 DJ Houghton CLA 2006-12-07 11:25:17 EST
This is not limited to MacOSX, I have reproduced this on WinXP.

Steps:
- install Eclipse 3.2
- connect to update site (Help -> Software Updates -> Find and Install -> New Versions of currently installed features)
- install Eclipse 3.2.1 update and Eclipse 3.2.1 feature patches 
- restart as required
- connect to update site

Note that the SDK 3.2.1 feature is still included in the list.

Also note that it doesn't seem to matter if you install 3.2.1 first and then restart and install the patches, or install all 4 features at once, you get the same result.
Comment 6 DJ Houghton CLA 2006-12-07 11:33:22 EST
Looks like it has to do with the feature patches. Once we install the feature patches, we invalidate the SDK feature because it includes exact versions of the old plug-ins/features.

Branko/Dejan, how do you recommend this be approached?
Comment 7 DJ Houghton CLA 2006-12-07 14:00:26 EST
*** Bug 167139 has been marked as a duplicate of this bug. ***
Comment 8 DJ Houghton CLA 2006-12-08 06:08:14 EST
*** Bug 167199 has been marked as a duplicate of this bug. ***
Comment 9 DJ Houghton CLA 2006-12-11 08:30:35 EST
*** Bug 166591 has been marked as a duplicate of this bug. ***
Comment 10 DJ Houghton CLA 2006-12-11 08:56:26 EST
*** Bug 166591 has been marked as a duplicate of this bug. ***
Comment 11 DJ Houghton CLA 2006-12-11 13:00:30 EST
*** Bug 167457 has been marked as a duplicate of this bug. ***
Comment 12 DJ Houghton CLA 2006-12-11 13:17:26 EST
*** Bug 166891 has been marked as a duplicate of this bug. ***
Comment 13 David Corley CLA 2006-12-13 07:54:29 EST
Bug also occuring on Win2K....
Comment 14 Jwahar Bammi CLA 2006-12-13 17:35:55 EST
See it occurring on Mac OSX (10.4.8), WinXP/SP2, Linux/Fedora fc6

Comment 15 Branko Tripkovic CLA 2006-12-13 18:27:51 EST
Created attachment 55622 [details]
patch

This patch fixes the problem by re-implementing deprecated accept methods in filter interface. This had to be done since there are still parts of the code working with those methods.
Comment 16 Dejan Glozic CLA 2006-12-13 19:00:30 EST
Definitely needs to be fixed in both 3.2.2 and in 3.3 M4. 

DJ, can you please set the PMC wheels to get this included. I think the list of dups for this defect is enough to warrant a 'must fix' status.

Comment 17 DJ Houghton CLA 2006-12-14 06:01:38 EST
Adding McQ to CC as PMC representative for his approval for release into 3.2.2.
Comment 18 Mike Wilson CLA 2006-12-14 10:51:28 EST
There's a "System.out.println(..." in the patch. Is it supposed to be there? (If not, can someone attach a correct patch)
Comment 19 Branko Tripkovic CLA 2006-12-14 14:40:07 EST
Created attachment 55699 [details]
new patch

MQ, can we get +1?
Comment 20 DJ Houghton CLA 2006-12-14 15:08:02 EST
*** Bug 168112 has been marked as a duplicate of this bug. ***
Comment 21 Mike Wilson CLA 2006-12-14 15:28:23 EST
+1
Comment 22 Alexander Portnov CLA 2006-12-14 17:31:22 EST
What I can also see is this message (in debug mode):
org.eclipse.core.runtime.CoreException: Unable to access archive C:\eclipse\plugins\org.eclipse.jdt.source_3.1.0\src\org.junit_3.8.1\junitsrc.zip
It's because it looking at wrong direction...
The correct one now (after last update) is:
C:\eclipse\plugins\org.eclipse.jdt.source_3.2.1.r321_v20060905-R4CM1Znkvre9wC-\src\org.junit_3.8.1
Does this put a bit more light on the problem?
Comment 23 DJ Houghton CLA 2006-12-15 15:38:35 EST
*** Bug 168017 has been marked as a duplicate of this bug. ***
Comment 24 Dejan Glozic CLA 2006-12-18 11:19:44 EST
The fix has been released to both 3.2.2 and 3.3 M4 streams.
Comment 25 Alexander Portnov CLA 2006-12-18 17:49:48 EST
Unfortunately, I can't reopen this bug...
I don't think it's resolved...
Just a few minutes ago I've been asked to repeat 4 times the same drill...
=================
Eclipse Project SDK

Version: 3.2.1.r321_v20060801-tQ1w49KnTArT0FZ
Build id: M20060921-0945
================
been installed/reinstalled 4 times, after that I just ignored the Update manager's proposal...
Comment 26 Nahor CLA 2006-12-18 20:23:35 EST
(In reply to comment #25)
> Unfortunately, I can't reopen this bug...
> I don't think it's resolved...

"The fix has been released to both *3.2.2* and *3.3 M4* streams." so wait for Eclipse 3.2.2 or 3.3 to be released first!
Comment 27 DJ Houghton CLA 2006-12-19 08:18:31 EST
This has been fixed in Eclipse 3.3 M4. (this was fixed in the client, it wasn't a server problem)

So if you are still using 3.2 and trying to update to the 3.2.1 patches (like the steps suggest) then unfortunatly you will still have this problem. 

If you are using 3.3 M4 and trying to update to a feature patch that you created (there are currently none available for the 3.3 stream on the official update site), then please let us know and we will re-open this report.

I don't know if this fix can be offered via a patch for 3.2.1 so users updating from 3.2 will be ok. I will investigate.
Comment 28 DJ Houghton CLA 2006-12-19 09:46:54 EST
Sorry, I was confused re: providing a patch. Since this is fixed in 3.2.2 once it is available and users upgrade to it, you won't see this problem anymore.
Comment 29 DJ Houghton CLA 2006-12-20 09:23:11 EST
*** Bug 168679 has been marked as a duplicate of this bug. ***
Comment 30 Tim Diggins CLA 2007-01-01 08:37:22 EST
(In reply to comment #28)
> Sorry, I was confused re: providing a patch. Since this is fixed in 3.2.2 once
> it is available and users upgrade to it, you won't see this problem anymore.
> 

Having read commentary so far, I understand that the bug is fixed for 3.2.2/3.3, but for 3.2.1 users, is there a workaround? (can one apply the patch to a released version of eclipse or only to the cvs version - the online docs, seem to suggest only a specific cvs version...) -- will the existence of this problem prevent further updates to 3.2.1 until fixed/move to 3.2.2? (assuming 3.2.2 will need new download rather than using update mechanism) 
Comment 31 DJ Houghton CLA 2007-01-02 10:09:52 EST
*** Bug 168955 has been marked as a duplicate of this bug. ***
Comment 32 Bill Brown CLA 2007-01-11 14:25:57 EST
Greetings: 

I updated to this build today and the error does not continue.  It may help users who cannot upgrade to the 3.3M or 3.2.2 builds.

Version: 3.2.1
Build id: M20070110-1900

Comment 33 DJ Houghton CLA 2007-01-24 14:46:30 EST
*** Bug 171589 has been marked as a duplicate of this bug. ***
Comment 34 DJ Houghton CLA 2007-01-31 09:37:20 EST
*** Bug 172246 has been marked as a duplicate of this bug. ***
Comment 35 DJ Houghton CLA 2007-02-13 06:36:58 EST
*** Bug 173973 has been marked as a duplicate of this bug. ***