Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 166578

Summary: Inconsistencies in the profiling options
Product: z_Archived Reporter: Alex Nan <apnan>
Component: TPTPAssignee: jkubasta
Status: CLOSED FIXED QA Contact:
Severity: major    
Priority: P1 CC: amehrega, ewchan, guru.nagarajan, jkubasta
Version: unspecifiedKeywords: plan
Target Milestone: ---   
Hardware: PC   
OS: Windows 2000   
Whiteboard:
Attachments:
Description Flags
updated doc
none
Patch with latest fixes
none
Screen cap for Execution Time Analysis
none
Screen cap for Memory Analysis
none
Screen cap for Thread Analysis
none
Screen cap for Probe Insertion
none
Latest html file containing links to new screen caps none

Description Alex Nan CLA 2006-12-01 19:19:53 EST
Build ID: TPTP-4.2.1.1-200611271752

Steps To Reproduce:
1. Launch an application in profiling mode using Basic Memory Analysis. Select the profiled agent, notice that the Collect Object References tool bar button is enabled. Right click and notice also that the Open with Object References menu item is available.
2. Launch an application with Execution Time Analysis ->Show execution statistics option. Notice that in the Edit Profiling Options dialog, the Collect instance level information check box is disabled although according to the docs it should be available. Notice also that the Collect Object References tool bar button is disabled.
3. Launch an application with Execution Time Analysis ->Show execution flow graphical details option. Notice that the Collect Object References tool bar button is enabled but the Open with Object references menu item is not available.
These are inconsistencies which would need to be clarified and fixed.
 



More information:
Comment 1 Eugene Chan CLA 2006-12-04 11:32:47 EST
(2) is a correct behavior and the documentation has to be updated.
Regarding (3) I agree this is confusing and Collect Object Reference button should be enabled and support all time, and object reference view should be enabled based on data availability and not profiling options.
Comment 2 jkubasta CLA 2007-04-15 11:00:05 EDT
For (2): Please tell me which doc files need to be updated and I will look into making the change(s)
Comment 3 Harm Sluiman CLA 2007-04-19 21:57:49 EDT
please target this to a valid target
Comment 4 Eugene Chan CLA 2007-04-20 00:23:52 EDT
Update target to i3
Comment 5 Eugene Chan CLA 2007-04-26 01:16:40 EDT
The doc in (2) is under org.eclipse.tptp.platform.doc.user/tasks/tefilter.htm

Table below 
"Profiling Java 1.4 and lower java virtual machine based applications"
needs to be updated.
Comment 6 jkubasta CLA 2007-04-26 22:22:40 EDT
So for 1, I see the toolbar but not the menu item;
For 2, toolbar is enabled (data sizes are all 0), menu item is not
For 3, toolbar is enabled (data sizes are all 0), menu item is not
Comment 7 jkubasta CLA 2007-04-26 22:26:56 EDT
Okay, my comments apply to Java 1.5; will retry with 1.4
Comment 8 jkubasta CLA 2007-04-26 22:36:20 EDT
Created attachment 65139 [details]
updated doc
Comment 9 jkubasta CLA 2007-04-26 22:37:37 EDT
I updated the docs to clarify some other steps.  I have not updated the table since it is not clear to me what needs to change.  After I retry with JVM 1.4 it might be clear
Comment 10 jkubasta CLA 2007-04-27 09:49:45 EDT
Okay, I can reproduce this as described on Java 1.4.  I will update the doc.
Comment 11 jkubasta CLA 2007-04-27 12:16:56 EDT
I have updated the docs.  A few things to note:
1) I added a section on Probe insertion and there may be a better opening line.  
2) All screen caps, with the exception of Profile Drop Down Menu, are out of date and need updating. 
3) I updated the Setting Profiling Options section to include information on Java 1.5 and higher.
4) I resolved broken links and edited the file.
Comment 12 jkubasta CLA 2007-04-27 12:19:18 EDT
Created attachment 65225 [details]
Patch with latest fixes
Comment 13 jkubasta CLA 2007-04-27 12:21:18 EDT
Added Guru because this deals with changes for JVMTI
Comment 14 jkubasta CLA 2007-04-27 20:03:01 EDT
The following screen caps need fixing:
img_mem_prof.png
img_prof_launch.png
img_thrd_prof.png
Comment 15 jkubasta CLA 2007-04-27 20:57:05 EDT
Created attachment 65293 [details]
Screen cap for Execution Time Analysis
Comment 16 jkubasta CLA 2007-04-27 20:58:23 EDT
Created attachment 65294 [details]
Screen cap for Memory Analysis
Comment 17 jkubasta CLA 2007-04-27 20:58:48 EDT
Created attachment 65295 [details]
Screen cap for Thread Analysis
Comment 18 jkubasta CLA 2007-04-27 20:59:56 EDT
Created attachment 65296 [details]
Screen cap for Probe Insertion

Note this function is currently not supported so the screen cap will need to be redone or removed (depending on whether this support is planned for 4.4)
Comment 19 jkubasta CLA 2007-04-27 21:37:09 EDT
Created attachment 65299 [details]
Latest html file containing links to new screen caps
Comment 20 jkubasta CLA 2007-05-01 17:03:34 EDT
Changes checked in.

Defect will remain open until Probe Insertion is enabled and a new screen cap is added. Please append to this defect if you think other changes are still needed.
Comment 21 jkubasta CLA 2007-05-02 19:11:49 EDT
New Probe Insertion screen cap added and probe insertion text modified slightly following discussion with Liz. Changes checked into head. New bugzilla opened to track request to make profiling options consistent on Java 1.4.2 in future:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=185259
Comment 22 Alex Nan CLA 2007-06-15 18:58:36 EDT
From the issues that I raised I notice that some of them were fixed, some not.
There is still at bullet 2) one issue remaining, that is the Open Object References main tool bar button is enabled although no object references profiling navigator view tool bar button is available and no object references view is available in the context menu.
Also the issue in bullet 3) is still reproduceable. One comment regarding bullet 3) is that the Open Object References main tool bar button is available.
OK I see now that a different defect was opened to track the issues that I raised. Anyway it seems that this defect was used for other work which seems to be reflected in the driver that I tested with TPTP-4.4.0-200706140100. I am gonna mark this defect as verified and close it.
Comment 23 Alex Nan CLA 2007-06-15 18:58:47 EDT
Closing...