Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 166219

Summary: [launching] Run Last Launched fails due to Launch Config Tree filter
Product: [Eclipse Project] JDT Reporter: Randy Hudson <hudsonr>
Component: DebugAssignee: Darin Wright <darin.eclipse>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 3.2.1   
Target Milestone: 3.3 M7   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Randy Hudson CLA 2006-11-29 11:49:27 EST
If Run... Dialog is filtering a launch config, CTRL+F11 fails to launch last, and opens the dialog instead. The user then decide to create a new launch config in the launch dialog that duplicates an existing one, and the new config itself gets filtered and can't even be seen the next time the dialog is opened.

So, while CTRL+F11 fails to re-launch, the User then attempts manual launch, Right-click on editor, Run As, SWT App. Now the user is prompted to choose a launch config as multiple have been created due to above filtering.

Proposed improvements:
1) Support CTRL+F11 always, regardless of what is filtered. In fact, the last launch should probably always appear in the history despite filter settings.

2) If the user opens the Run... dialog and creates a duplicate config, indicate this to the user, and perhaps suggest removing the filter(s) hiding the existing config.
Comment 1 Michael Rennie CLA 2007-03-20 16:34:46 EDT
Ctrl+F11 will only open the launch dialog if there is nothing to run last

From my testing with the filters there is no way to create a "duplicate" config in the way you describe except using working set filtering (which is then filtered if I reopen the dialog). 

For example, with Java Applications, if you create a new config, and you hit the browse button for projects, it will show you projects that are currently filtered due to workingsets, which it should not do. Doing this will allow you to create a "duplicate" config as you describe, and cause all of the other issues you describe.

I think the better solution here would be to fully support workingset filters. This would however require other consumers of browsing for config attributes to also properly support working set filters, which as you can imagine could be quite problematic. The other alternative would be to remove working set filters
Comment 2 Randy Hudson CLA 2007-04-03 11:56:14 EDT
(In reply to comment #1)
> Ctrl+F11 will only open the launch dialog if there is nothing to run last

The request is to change *when* there is nothing to run last. Currently, if I just ran something, and I try to run it again, it fails because of the filter. It should only fail when I have deleted the launch configuration, or in other normal cases.

Run Last Launched appears on the main Run menu. There is no way for the user to know if the Run... dialog is using workingset filters. Probably, the user doesn't even care, and just wants to "Run Last Launched".
Comment 3 Michael Rennie CLA 2007-04-04 16:39:55 EDT
You are right Randy, as such we have removed the working set filter from use anywhere except in the launch dialog. We found that it caused alot more trouble with the new context launching than it did with normal launching. However the remainder of the filtering is still done (deleted project, closed project, etc).

fixed in HEAD

changes to LaunchConfigurationManager, DebugUIPlugin, and a pile of window actions
Comment 4 Michael Rennie CLA 2007-04-04 16:41:15 EDT
please verify Darin W
Comment 5 Darin Wright CLA 2007-04-05 10:15:00 EDT
Verified.