Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 165936

Summary:

Some AGR test suites need to be refactored

Product:

z_Archived

Reporter:

Ruth Lee <ruthdaly>

Component:

TPTP

Assignee:

Liz Dancy <lizdancy>

Status:

CLOSED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

ewchan, nmehrega

Version:

unspecified

Target Milestone:

---

Hardware:

OS:

Windows 2000

Whiteboard:

closed460

Bug Depends on:

Bug Blocks:

165804

Attachments:

Description	Flags
Patch for refactored test suites	none
Platform.UI.ProfilingPerspective.Launch.Part4 (refactored)	none
Platform.UI.ProfilingPerspective.Launch.Part5 (refactored)	none
LaunchPart4_TestSuite	none
LaunchPart4_VerificationHookClass	none

Description Ruth Lee

2006-11-27 12:06:13 EST

Some of our existing AGR test suites are poorly designed and don't really
follow all best practice guidelines mentioned in the following document: 
http://www.eclipse.org/tptp/home/documents/process/TPTP_Testing_Strategy.html#2.2.2

Currently, the object mine is centralized under
Platform.UI.ProfilingPerspective.Launch.  Through practice, I've found that
centralizing object mines under one test suite makes it difficult to debug/fix
a macro.  A test suite's object mine should only be bounded to itself.

Liz, this is one defect for refactoring some of the AGR test suites. Can you take care of the following, please:
The test suites are all under
org.eclipse.hyades.use.cases/gui/Profiling_and_Logging/Launch:

Platform.UI.ProfilingPerspective.Launch.Part4.testsuite
Platform.UI.ProfilingPerspective.Launch.Part5.testsuite

Comment 1 Eugene Chan

2006-11-27 12:10:50 EST

Target 4.4. Refactor work should be started as soon as 4.3 work is completed.

Comment 2 Liz Dancy

2006-11-28 08:54:53 EST

Changing to P1 to indicate that this work will be started shortly.

Comment 3 Liz Dancy

2006-12-06 09:58:41 EST

Created attachment 55133 [details]
Patch for refactored test suites

Test suites patch (src and datapool files)

Comment 4 Liz Dancy

2006-12-06 10:00:07 EST

Created attachment 55134 [details]
Platform.UI.ProfilingPerspective.Launch.Part4 (refactored)

Comment 5 Liz Dancy

2006-12-06 10:01:10 EST

Created attachment 55135 [details]
Platform.UI.ProfilingPerspective.Launch.Part5 (refactored)

Comment 6 Liz Dancy

2006-12-06 10:02:21 EST

I have attached everything needed for review/check-in. Please advise of any suggested changes.

Comment 7 Liz Dancy

2007-02-08 11:28:09 EST

Updated sizing.

Comment 8 Liz Dancy

2007-02-09 09:39:07 EST

Targetting to 4.4i2 to coincide with the addition of the second refactoring defect (165935). It makes the most sense if I work on these in parallel.

Comment 9 Liz Dancy

2007-02-19 14:32:39 EST

Created attachment 59300 [details]
LaunchPart4_TestSuite

Comment 10 Liz Dancy

2007-02-19 14:33:04 EST

Created attachment 59301 [details]
LaunchPart4_VerificationHookClass

Comment 11 Liz Dancy

2007-02-25 12:09:38 EST

Files have been checked in and used for 4.4 i1 TP2. Closing defect.

Comment 12 Paul Slauenwhite

2009-06-30 09:47:54 EDT

As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this originator of this enhancement/defect has an inactive Bugzilla account and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.

Comment 13 Paul Slauenwhite

2009-06-30 09:48:35 EDT

As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this originator of this enhancement/defect has an inactive Bugzilla account and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.