Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 165169

Summary: Scrollbar issues on image attachment preview
Product: z_Archived Reporter: Willian Mitsuda <wmitsuda>
Component: MylynAssignee: Willian Mitsuda <wmitsuda>
Status: RESOLVED FIXED QA Contact:
Severity: minor    
Priority: P4 Keywords: helpwanted
Version: 0.9   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Patch
none
mylar/context/zip
none
Patch
none
mylar/context/zip
none
Another patch
none
mylar/context/zip none

Description Willian Mitsuda CLA 2006-11-20 11:13:12 EST 
Steps to reproduce:

- Try to attach a .gif file to a bug report.
- On the preview wizard page, click on the middle of vertical scrollbar (haven't tried with horizontal scroll).
- It moves only a few pixels.
Comment 1 Mik Kersten CLA 2006-11-22 15:49:33 EST 
There also seems to be some weirdness with the background if it is transparent.
Comment 2 Willian Mitsuda CLA 2006-11-25 16:25:41 EST 
Created attachment 54517 [details]
Patch

I also simplified the code a lot.
Comment 3 Willian Mitsuda CLA 2006-11-25 16:25:44 EST 
Created attachment 54518 [details]
mylar/context/zip
Comment 4 Willian Mitsuda CLA 2006-11-25 16:27:07 EST 
About the transparent background, do you have some sample image? What happens?
Comment 5 Mik Kersten CLA 2006-11-26 23:05:20 EST 
Good stuff Willian, patch applied.  This also fixed the transparency problem I was seeing, where the Mylar icons would have black artifacts in their transparent regions.
Comment 6 Willian Mitsuda CLA 2006-11-29 19:17:29 EST 
Mik, there was a image leak that I forgot to fix.

Can you please apply the patch bellow?
Comment 7 Willian Mitsuda CLA 2006-11-29 19:23:13 EST 
Created attachment 54758 [details]
Patch
Comment 8 Willian Mitsuda CLA 2006-11-29 19:23:16 EST 
Created attachment 54759 [details]
mylar/context/zip
Comment 9 Mik Kersten CLA 2006-12-02 09:08:41 EST 
Patch applied.  Great that you found that Willian.
Comment 10 Willian Mitsuda CLA 2006-12-05 11:55:10 EST 
Reopening again because I just saw that it is not working when the image comes initially with scrollbars. The page size is adjusted just after a window resize.

I'll take a look at this tonight.
Comment 11 Mik Kersten CLA 2006-12-18 23:34:29 EST 
Anything left on this Willian?
Comment 12 Willian Mitsuda CLA 2006-12-19 09:11:29 EST 
(In reply to comment #11)
> Anything left on this Willian?
> 

Sorry, but I've been busy this week, and the scrollbar configuration concepts are a little hard to understand.

I think I'll have some time to investigate this next week.

Since this is a minor bug, I think we could just go without it for 1.0.1.
Comment 13 Mik Kersten CLA 2006-12-19 12:39:10 EST 
Sounds good.
Comment 14 Willian Mitsuda CLA 2006-12-24 21:16:25 EST 
Created attachment 56153 [details]
Another patch

I hope this is the last one :)

This fixes the initial scrollbar calculation. Also, it fixes a flicker problem I was having while scrolling big screenshots.
Comment 15 Willian Mitsuda CLA 2006-12-24 21:16:34 EST 
Created attachment 56154 [details]
mylar/context/zip
Comment 16 Mik Kersten CLA 2007-01-05 17:09:00 EST 
Patch applied and verified with large screenshot.