Bugzilla – Full Text Bug Listing
| Summary: | when submitting changes from a rich editor into the repository, it would be nice to see who were notified | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Erkki Lindpere <villane> | ||||||||||||||
| Component: | Mylyn | Assignee: | Frank Becker <eclipse> | ||||||||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||||||||
| Severity: | enhancement | ||||||||||||||||
| Priority: | P3 | CC: | eclipse, ekuleshov, robert.elves, steffen.pingel, wmitsuda | ||||||||||||||
| Version: | unspecified | Keywords: | helpwanted | ||||||||||||||
| Target Milestone: | 3.2 | ||||||||||||||||
| Hardware: | All | ||||||||||||||||
| OS: | All | ||||||||||||||||
| Whiteboard: | |||||||||||||||||
| Bug Depends on: | 202879 | ||||||||||||||||
| Bug Blocks: | |||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Erkki Lindpere
It's best if we do this for one connector first, and then try to generalize it. Since we would ideally show this in the editor before submission, we would need a facility for determining who will get notified. Alternatively if we did get a status on notification back, or a web page in the case of the web connector, we could try to figure out UI for showing that. I don't think that we should show a dialog each time though. Yes, a dialog each time would be annoying. Maybe something like the incoming task notifications and clicking on that notification could open a dialog. A design for this is needed before we proceed with an implementation. It is feasible that we could have this in some kind of on-demand (e.g. tooltip) popup in some portion of the Task Editor, but the UI design will be tricky since there is no precedent for this kind of notification in the Eclipse UI. (In reply to comment #3) > A design for this is needed... [chop] You could simply show that list in the tooltip for the status message shown in the same place where warnings and errors are being shown. (In reply to comment #4) > You could simply show that list in the tooltip for the status message shown in > the same place where warnings and errors are being shown. That's a reasonable suggestion, although it would mean that this transient information would commonly make the top of the editor very busy looking. But this would be a good place to start and we could iterate on the UI later. This is still not a good bugday candidate because it has other dependencies, but help is certainly welcome from anyone interested in tackling this one. I created bug 202879 for the API dependency, so if anyone is looking at this please feel free to push us on doing that. Resolving this would also likely require screen scraping the response from Bugzilla, so please inquire with Rob about that because different localizations and customizations of Bugzilla make parsing that response fragile. (In reply to comment #5) > That's a reasonable suggestion, although it would mean that this transient > information would commonly make the top of the editor very busy looking. I was saying that info message would read "submitted successfully" and tooltip for that message would show all the details Created attachment 135069 [details] patch Here is a Patch using th API from bug#202879#c18 Other things: In BugzillaClient I add some //$NON-NLS- Created attachment 135070 [details]
mylyn/context/zip
The patch looks good to me. One change I would like to suggest is to create a BugzillaRepositoryResponse class that holds the additional fields and cast that in BugzillaTaskEditor instead of changing RepositoryResponse. When I tested the patch with http://mylyn.eclipse.org/bugs30/show_bug.cgi?id=30 I noticed that the message in the Task Editor only said "Excluding..." but omitted the "Email sent to..." part which made it less clear. Full message from the web interface: Changes submitted for bug 30 Email sent to: no one Excluding: tests@mylyn.eclipse.org I'll tentatively put this on for 3.2. Rob, what are your thoughts? Created attachment 136642 [details] updated patch (In reply to comment #9) > The patch looks good to me. One change I would like to suggest is to create a > BugzillaRepositoryResponse class that holds the additional fields and cast that > in BugzillaTaskEditor instead of changing RepositoryResponse. > > When I tested the patch with http://mylyn.eclipse.org/bugs30/show_bug.cgi?id=30 > I noticed that the message in the Task Editor only said "Excluding..." but > omitted the "Email sent to..." part which made it less clear. Full message from > the web interface: > > Changes submitted for bug 30 > > Email sent to: > no one > Excluding: > tests@mylyn.eclipse.org This is because the parse of the html looks only for <dt> and <code> tag but 'no one' is not between <code> and </code>. Should I fix this by implement an complexer parse? > > I'll tentatively put this on for 3.2. Rob, what are your thoughts? Created attachment 136643 [details]
mylyn/context/zip
Patch looks good to me. I only have a few suggestions: * Change the condition in BugzillaTaskEditorPage.handleTaskSubmitted() to this: if (event.getJob().getStatus() == null && event.getJob().getResponse() instanceof BugzillaRepositoryResponse) * Use NLS.bind() instead of MessageFormat.format(), it works the same way. * If parsing of the response of a successful submission fails, should we just ignore IOException and return a successful status? Frank, can you make these changes and then go ahead and commit? Created attachment 137235 [details] commited patch comment#12 is now included Created attachment 137236 [details]
mylyn/context/zip
patch is commited I like this feature a lot, thanks! I had one confusion, however. The basic messaging of the popup is great in most cases:
Email sent to:
no one
Excluding:
tests@mylyn.eclipse.org
However, when I clicked on the message for the first time I saw:
Excluding:
tests@mylyn.eclipse.org
When the message does not include the "email sent to" part the "excluding" label doesn't have a clear meaning.
Can someone please clarify, if I am not mistaken it now adds the link to the editor header area and user can click on it to see the information about notified parties. But then submission triggers a background task job that can refresh the editor, so this link will be gone when refresh is completed. Am I right? (In reply to comment #16) > I like this feature a lot, thanks! I had one confusion, however. The basic > messaging of the popup is great in most cases: > Email sent to: > no one > Excluding: > tests@mylyn.eclipse.org > However, when I clicked on the message for the first time I saw: > Excluding: > tests@mylyn.eclipse.org > When the message does not include the "email sent to" part the "excluding" > label doesn't have a clear meaning. > Here we have the problem that the html returned by Bugzilla is hard to parse. Please see comment#10. Hope that an newer Bugzilla version (>3.4) generate better html or we can switch to the Webservice API when all needed information are included. (In reply to comment #17) > Can someone please clarify, if I am not mistaken it now adds the link to the > editor header area and user can click on it to see the information about > notified parties. But then submission triggers a background task job that can > refresh the editor, so this link will be gone when refresh is completed. Am I > right? The feature is now available on the weekly site. Please try it and reopen this bug if you are encountering unexpected behavior. |