Bugzilla – Full Text Bug Listing
| Summary: | [About] Eclipse uses the branding plug-in's name to display the feature name rather than the feature's name from the feature.xml file | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Alex Le <unbonnevie> |
| Component: | UI | Assignee: | Platform UI Triaged <platform-ui-triaged> |
| Status: | CLOSED WONTFIX | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | christian.weinreben, clovis.seragiotto, curtispd, dash.alpha, davidms, david_williams, eclipse.sprigogin, eric.milles, heiko.boettger, matthias.schmalz, mober.at+eclipse, nyssen, per.mildner, picard, sbouchet, spacehorst, stori, tgrimault, udojung |
| Version: | 3.2 | Keywords: | helpwanted |
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Whiteboard: | stalebug | ||
|
Description
Alex Le
I was also confused by this the first time I saw it. *** Bug 164189 has been marked as a duplicate of this bug. *** *** Bug 168188 has been marked as a duplicate of this bug. *** This behaves the same in eclipse 3.4 still and is confusing, was there a reason the branding plugin name was every used instead? I don't understand why I have to even make a branding plugin for every single feature I have just so the feature info gets displayed appropriately in the "about" UI... My understanding is that features don't really exist at runtime: they just help update manager/p2 determine what plug-ins to run together. So, all of the information in feature.xml is available for display in the update UI, but not available in the active platform into which features are installed. That's why we need branding plug-ins in the first place. However, it still seems quite wrong to be using the bundle name of the branding plug-in because the branding plug-in may also be just one of several plug-ins in the feature. For example, in EMF, we have an org.eclipse.emf.ecore feature, which provides just the EMF core runtime. In includes EMF's common utilities (plug-in org.eclipse.emf.common), Ecore (org.eclipse.emf.ecore), the change model (org.eclipse.emf.ecore.change), and XML persistence support (org.eclipse.emf.ecore.xmi). The branding plug-in is org.eclipse.emf.ecore, and its bundle name is "EMF Ecore". However, the feature name should be "EMF Core Runtime" to reflect the fact that it contains more than *just* Ecore. We've set label to that in the feature.xml file, but there's no way to make that name show up in the About dialog. Users just see "EMF Ecore." Given that the about.ini file in a branding plug-in provides other feature data that's needed by the About dialog (aboutText and featureImage), I think it would make perfect sense to add support for a featureName key that could be used to specify a name for the whole feature. Such a value would be used if specified. Otherwise, the branding plug-in's bundle name would be used as a fallback. reassigning remaining [About] bugs according to 2009 platform-ui triage guidelines Any idea when this will be addressed. It's been over 4 years and has been in triage for almost 2 years. Thanks Alain (In reply to comment #7) > Any idea when this will be addressed. It's been over 4 years and has been in > triage for almost 2 years. > > Thanks > Alain I'm not sure there's been convergence on what the solution should be. Comment #5 suggests a key be added to about.ini, does that solve the problem for those who have voted on this bug? *** Bug 277594 has been marked as a duplicate of this bug. ***
> I'm not sure there's been convergence on what the solution should be. Comment
> #5 suggests a key be added to about.ini, does that solve the problem for those
> who have voted on this bug?
IMHO it does not solve the big problem, but maybe it is the "best that can be done" without breaking behavior?
I'm not sure why it can't actually read the feature name. To me, if memory serves me, the issue is that one branding plugin should be able to be used for a collection of features. I think now, the deciding characteristic of whether or not features should be collected under the same "icon" in the about box is if all the branding plugins use the exact same icon. Seems to me it should be simply if the features they use the same branding plugin. Otherwise, feature providers must a) provide multiple branding bundles, each of which does not do much other than provide an icon (and, as it stands now, labels to be used in about box), and b) must make sure they each use exactly the same icon, in order to "group" them together. Seems an odd criteria for grouping, when you could just use the branding bundle itself. But, I realize you may need to maintain previous behavior, and might be hard to come up with the ideal solution.
In addition to the feature name, also the feature vendor and copyright notice (which should be in about.ini) are taken from the branding plugin. We are using the license-feature technique to have licenses for all features stored centrally, but this way, it doesn't work for vendor and copyright. It would be helpful to make this available via key, too. As the feature id is extracted when opening the about dialog, and shown in column feature-id, this should be the right place for accessing the possibly externalized feature-name inside feature.xml. Can anyone tell me if there will be a fix? *** Bug 413374 has been marked as a duplicate of this bug. *** This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug. If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie. |