Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 163088

Summary: TPTP Monitoring Project Hygiene -- correct bad/missing/incorrect copyright statements, and incorrect plugin versions
Product: z_Archived Reporter: Joe Toomey <jptoomey>
Component: TPTP.monitoringAssignee: Andrew Eberbach <aeberbac>
Status: CLOSED FIXED QA Contact:
Severity: critical    
Priority: P1 CC: smith
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard: closed460
Bug Depends on: 163068    
Bug Blocks: 162760    

Description Joe Toomey CLA 2006-11-01 11:12:16 EST
The monitoring project still has the following hygiene issues to correct for 4.3.  These changes have already been approved by the PMC under https://bugs.eclipse.org/bugs/show_bug.cgi?id=162760

Please ensure that these issues are addressed ASAP.

Monitoring files missing copyright notices:

plugins/org.eclipse.tptp.monitoring.instrumentation/src.probes/CbeCallSiteProbe_probe.java
plugins/org.eclipse.tptp.monitoring.instrumentation/src.probes/CbeProbe_probe.java
plugins/org.eclipse.tptp.monitoring.instrumentation/src.probes/JMXProbe_probe.java


Monitoring files with incorrect copyright dates:

plugins/muse.osgi.core/SOAP-Envelope-1_2.xsd
plugins/org.eclipse.tptp.wsdm.tooling.model/artifacts/managementCapabilities/SOAP-Envelope-1_2.xsd
plugins/org.eclipse.tptp.wsdm.tooling.model/artifacts/managementCapabilities/WS-BaseFaults-1_2.xsd
plugins/org.eclipse.tptp.wsdm.tooling.model/artifacts/managementCapabilities/WS-BaseNotification-1_3.xsd
plugins/org.eclipse.tptp.wsdm.tooling.model/artifacts/managementCapabilities/WS-Resource-1_2.xsd
plugins/org.eclipse.tptp.wsdm.tooling.model/artifacts/managementCapabilities/WS-Resource.wsdl
plugins/org.eclipse.tptp.wsdm.tooling.model/artifacts/managementCapabilities/WS-ResourceLifetime-1_2.xsd
plugins/org.eclipse.tptp.wsdm.tooling.model/artifacts/managementCapabilities/WS-ResourceLifetime.wsdl
plugins/org.eclipse.tptp.wsdm.tooling.model/artifacts/managementCapabilities/WS-ResourceProperties-1_2.xsd
plugins/org.eclipse.tptp.wsdm.tooling.model/artifacts/managementCapabilities/WS-ResourceProperties.wsdl
plugins/org.eclipse.tptp.wsdm.tooling.model/artifacts/managementCapabilities/WS-Topics-1_3.xsd
plugins/org.eclipse.tptp.wsdm.tooling.model/artifacts/managementRelatedCapabilities/NotificationConsumer.wsdl
plugins/org.eclipse.tptp.wsdm.tooling.model/artifacts/managementRelatedCapabilities/NotificationProducer.wsdl
plugins/org.eclipse.tptp.wsdm.tooling.model/artifacts/managementRelatedCapabilities/WS-BaseFaults-1_2.xsd
plugins/org.eclipse.tptp.wsdm.tooling.model/artifacts/managementRelatedCapabilities/WS-BaseNotification-1_3.xsd
plugins/org.eclipse.tptp.wsdm.tooling.model/artifacts/managementRelatedCapabilities/WS-Resource-1_2.xsd
plugins/org.eclipse.tptp.wsdm.tooling.model/artifacts/managementRelatedCapabilities/WS-Resource.wsdl
plugins/org.eclipse.tptp.wsdm.tooling.model/artifacts/managementRelatedCapabilities/WS-Topics-1_3.xsd
plugins/org.eclipse.tptp.wsdm.tooling.model/artifacts/resourceLifetimeCapabilities/WS-BaseFaults-1_2.xsd
plugins/org.eclipse.tptp.wsdm.tooling.model/artifacts/resourceLifetimeCapabilities/WS-Resource-1_2.xsd
plugins/org.eclipse.tptp.wsdm.tooling.model/artifacts/resourceLifetimeCapabilities/WS-Resource.wsdl
plugins/org.eclipse.tptp.wsdm.tooling.model/artifacts/resourceLifetimeCapabilities/WS-ResourceLifetime-1_2.xsd
plugins/org.eclipse.tptp.wsdm.tooling.model/artifacts/resourcePropertyCapabilities/WS-BaseFaults-1_2.xsd
plugins/org.eclipse.tptp.wsdm.tooling.model/artifacts/resourcePropertyCapabilities/WS-Resource-1_2.xsd
plugins/org.eclipse.tptp.wsdm.tooling.model/artifacts/resourcePropertyCapabilities/WS-Resource.wsdl
plugins/org.eclipse.tptp.wsdm.tooling.model/artifacts/resourcePropertyCapabilities/WS-ResourceProperties-1_2.xsd
plugins/org.eclipse.tptp.wsdm.tooling.model/artifacts/resourceTypes/WS-BaseFaults-1_2.xsd
plugins/org.eclipse.tptp.wsdm.tooling.model/artifacts/resourceTypes/WS-BaseNotification-1_3.xsd
plugins/org.eclipse.tptp.wsdm.tooling.model/artifacts/resourceTypes/WS-Resource-1_2.xsd
plugins/org.eclipse.tptp.wsdm.tooling.model/artifacts/resourceTypes/WS-Resource.wsdl
plugins/org.eclipse.tptp.wsdm.tooling.model/artifacts/resourceTypes/WS-Topics-1_3.xsd
plugins/org.mx4j.jmx/LICENSE.jmx-software.txt
Comment 1 Dave Smith CLA 2006-11-01 12:20:09 EST
Matt, please add copyright comments to the probe source files.  Navid, provided the following instructions for doing this:

Specify the comments in the beginning of the 'Fragment At Class Scope'.  To do this, simply select the 'Probe' entry in the probekit editor and specify the copyright comments in the text field that opens up on the right side of the editor.

Note, the copyright comment will be included within the class definition instead of the top of the file but that should be acceptable.

For the incorrect copyright year list, all of the .xsd and .wsdl files will be removed from TPTP for 4.3 with bugzilla https://bugs.eclipse.org/bugs/show_bug.cgi?id=163068

Matt correct me if I am wrong but the copyright in plugins/org.mx4j.jmx/LICENSE.jmx-software.txt cannot be changed because it was taken from the third party MX4J package which we have approval to package with TPTP.
Comment 2 Matt Mings CLA 2006-11-01 15:54:49 EST
added copyrights to:
plugins/org.eclipse.tptp.monitoring.instrumentation/src.probes/CbeCallSiteProbe_probe.java
plugins/org.eclipse.tptp.monitoring.instrumentation/src.probes/CbeProbe_probe.java
plugins/org.eclipse.tptp.monitoring.instrumentation/src.probes/JMXProbe_probe.java

plugins/org.mx4j.jmx/LICENSE.jmx-software.txt was taken from a third party
Comment 3 Dave Smith CLA 2006-11-01 15:56:30 EST
Andrew, please close this defect when 163068 is fixed.
Comment 4 Andrew Eberbach CLA 2006-11-09 16:31:43 EST
Removed offending files
Comment 5 Paul Slauenwhite CLA 2009-06-30 12:13:49 EDT
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.