Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 161627

Summary: Query hits with no task are not showing on Open/Activate Task dialogs
Product: z_Archived Reporter: Willian Mitsuda <wmitsuda>
Component: MylynAssignee: Mik Kersten <mik.kersten>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 Keywords: helpwanted
Version: dev   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
mylar/context/zip none

Description Willian Mitsuda CLA 2006-10-19 15:00:02 EDT 
Only query hits which have a associated task are displayed on the latest dev-build.
Comment 1 Mik Kersten CLA 2006-10-19 23:39:04 EDT 
Fixed.

Rob: note that this was one place where the change to not have query.getChildren() return hits caused this small regression.  We're going to need to look at the design here and consider whether hits should be a kind of ITask even though they don't have local data.
Comment 2 Mik Kersten CLA 2006-10-19 23:39:05 EDT 
Created attachment 52371 [details]
mylar/context/zip
Comment 3 Willian Mitsuda CLA 2006-10-20 10:24:16 EDT 
(In reply to comment #1)
> We're going to
> need to look at the design here and consider whether hits should be a kind of
> ITask even though they don't have local data.
> 

This is one thing that confused me the first time I looked at the source code, this distinction between a task and query hit, because they have a lot in common.

There is something a little strange yet in this design, perhaps extract a superinterface of ITask and query hit.

There is a lot of code in mylar that iterates over a collection of tasks and after that iterates over a collection of query hits. This way it can be simplified.
Comment 4 Mik Kersten CLA 2006-10-20 11:40:40 EDT 
Yes, well put and this refactoring is long overdue.  Created bug 161734.