Bugzilla – Full Text Bug Listing
| Summary: | favicon support for repositories | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Andrew Overholt <overholt> | ||||||
| Component: | Mylyn | Assignee: | Project Inbox <mylyn-triaged> | ||||||
| Status: | CLOSED MOVED | QA Contact: | |||||||
| Severity: | enhancement | ||||||||
| Priority: | P4 | CC: | klee, leo.dos.santos | ||||||
| Version: | unspecified | Keywords: | helpwanted | ||||||
| Target Milestone: | --- | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Andrew Overholt
We currently have the notion of a "branding" icon for each repository kind. These icons show in three kinds of places: 1) Icons in viewers that show repository connectors: http://www.eclipse.org/mylar/doc/images/0.6.1/trac-add-repository.gif 2) Icon overlays in viewers that show task repositories, e.g.: http://www.eclipse.org/mylar/doc/images/0.7.0/task-repository-association.gif 3) Icons tooltips for repository tasks: http://www.eclipse.org/mylar/doc/images/0.4.10/tasklist-status.gif For the Task List itself we have taken the approach of making all of the iconography have a meaning, and not showing any branding since it can lead to visual noise. However, I can see how this could be a good way of exposing repository-specific branding (e.g. Red Hat). So what if we incorporate that icon into (2) and (3)? We would still likely want to retain the blue repository icon somehow for (2) in order to provide visual consistency and stay in the spiring of the Eclipse UI guidelines. Yes, I was thinking of using it in (2) and (3) but also in-line with the repository address. Actually, I now see that repository tasks don't all have the repository URL visible. Perhaps we can add the favicon -- if it's present -- beside the repository id #? Something like: Description ======= *icon* <repository #>: <description> Sorry, I'm confused, are you referring to adding it to the task editor? (In reply to comment #3) > Sorry, I'm confused, are you referring to adding it to the task editor? No, I meant display it in the Task List view. If you mean in the tooltip popup, (3) in my comment#1, then yes, your proposal sound good to me. if you mean to show the favicon in the the Task List table itself then I think that this would result in a huge amount of visual noise without adding much? Created attachment 52279 [details]
favicon in task list
I mean something like this. It's obviously up to you if you think it adds too much visual noise but for people working with different bugzilla systems all the time, it would greatly help IMHO.
I do think that the branding will be too noisy in the Task List. Branding icons tend not to follow the visual design criteria of Eclipse, and while they are often recognizable do not have a clear and generic iconography. For this reason we are adhering to not not showing any branding in the always visible parts of the Task List. However, they can be very useful in other parts of the UI where they can help disambiguate items, which is why we do use branding icons in the Task List tooltips and in wizard dialogs. If someone provides a patch to retrieve the icons, we can add them where we currently have repository-specific icons only (e.g. Bugzilla vs. JIRA). We can then explore surfacing them in other parts of the UI. The patch can come from the original Platform/Team plug-in since that was under the EPL and on eclipse.org. The task editor form layout has a title banner across the top with the repository label (or url) on the right. It may make sense to prefix the label with the favicon. Thoughts? Andrew: if we do find a place to do this can you provide a patch with the .ico reading support? Or is there Java API for that? (In reply to comment #9) > Andrew: if we do find a place to do this can you provide a patch with the .ico > reading support? Or is there Java API for that? I'll try to dig through the old bugzilla plugin and grab that bit. Created attachment 61599 [details]
patch for retrieving favicons
Excellent. Patch applied. So, this is just an util to get the icon? It is not cached locally and not really shown anywhere... (In reply to comment #13) > So, this is just an util to get the icon? It is not cached locally and not > really shown anywhere... Correct, we'll need to cache these and then will be displaying them for example in editor header. If you need some pointers how to cache the favicon, I am doing all this in rssowl2 (https://rssowl.svn.sourceforge.net/svnroot/rssowl/plugins/org.rssowl.ui/trunk/src/org/rssowl/ui/internal/RSSOwlUI.java) Btw, I had some troubles with favicons due to different formats and/or varying icon sizes. The solution I use now is not involving any URLImageDescriptor but plain SWT and I am trying various formats before returning NULL (indicating being unable to read the favicon). Maybe this happens with your solution as well, then you might want to check the storeImage() method. Mylyn has been restructured, and our issue tracking has moved to GitHub [1]. We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub. [1] https://github.com/orgs/eclipse-mylyn |
