Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 161121

Summary:	[History View] recursive attempt to activate part org.eclipse.team.ui.GenericHistoryView
Product:	[Eclipse Project] Platform	Reporter:	Boris Bokowski <bokowski>
Component:	Team	Assignee:	Michael Valenta <Michael.Valenta>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	3.3
Target Milestone:	3.3 M5
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Boris Bokowski

2006-10-16 15:35:10 EDT

[I20061010-0800]

Found this in my log:
java.lang.RuntimeException: WARNING: Prevented recursive attempt to activate part org.eclipse.team.ui.GenericHistoryView while still in the middle of activating part org.eclipse.team.sync.views.SynchronizeView
at org.eclipse.ui.internal.WorkbenchPage.setActivePart(WorkbenchPage.java:3133)
at org.eclipse.ui.internal.WorkbenchPage.requestActivation(WorkbenchPage.java:2726)
at org.eclipse.ui.internal.PartPane.requestActivation(PartPane.java:256)
at org.eclipse.ui.internal.PartPane.handleEvent(PartPane.java:220)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:928)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:952)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:933)
at org.eclipse.swt.widgets.Shell.setActiveControl(Shell.java:1227)
at org.eclipse.swt.widgets.Control.sendFocusEvent(Control.java:2000)
at org.eclipse.swt.widgets.Widget.wmSetFocus(Widget.java:2169)
at org.eclipse.swt.widgets.Control.WM_SETFOCUS(Control.java:3873)
at org.eclipse.swt.widgets.Control.windowProc(Control.java:3329)
at org.eclipse.swt.widgets.Text.windowProc(Text.java:1841)
at org.eclipse.swt.widgets.Display.windowProc(Display.java:4080)
at org.eclipse.swt.internal.win32.OS.SetFocus(Native Method)
at org.eclipse.swt.widgets.Control.forceFocus(Control.java:746)
at org.eclipse.swt.widgets.Control.setFocus(Control.java:2331)
at org.eclipse.team.internal.ccvs.ui.CVSHistoryPage.inputSet(CVSHistoryPage.java:1695)
at org.eclipse.team.ui.history.HistoryPage.setInput(HistoryPage.java:56)
at org.eclipse.team.internal.ui.history.GenericHistoryView.itemDropped(GenericHistoryView.java:454)
at org.eclipse.team.internal.ui.history.GenericHistoryView$3.selectionChanged(GenericHistoryView.java:162)
at org.eclipse.ui.internal.AbstractSelectionService.fireSelection(AbstractSelectionService.java:156)
at org.eclipse.ui.internal.AbstractSelectionService.setActivePart(AbstractSelectionService.java:282)
at org.eclipse.ui.internal.WorkbenchPagePartList.fireActivePartChanged(WorkbenchPagePartList.java:59)
at org.eclipse.ui.internal.PartList.setActivePart(PartList.java:126)
at org.eclipse.ui.internal.WorkbenchPage.setActivePart(WorkbenchPage.java:3183)
at org.eclipse.ui.internal.WorkbenchPage.activate(WorkbenchPage.java:585)
at org.eclipse.ui.internal.WorkbenchPage.makeActive(WorkbenchPage.java:1147)
at org.eclipse.ui.internal.WorkbenchPage.updateActivePart(WorkbenchPage.java:1127)
at org.eclipse.ui.internal.WorkbenchPage.updateVisibility(WorkbenchPage.java:3351)
at org.eclipse.ui.internal.WorkbenchPage.setPerspective(WorkbenchPage.java:3266)
at org.eclipse.ui.internal.WorkbenchPage.busySetPerspective(WorkbenchPage.java:954)
at org.eclipse.ui.internal.WorkbenchPage.access$12(WorkbenchPage.java:938)
at org.eclipse.ui.internal.WorkbenchPage$12.run(WorkbenchPage.java:3384)
at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:67)
at org.eclipse.ui.internal.WorkbenchPage.setPerspective(WorkbenchPage.java:3382)
at org.eclipse.ui.internal.PerspectiveBarContributionItem.select(PerspectiveBarContributionItem.java:123)
at org.eclipse.ui.internal.PerspectiveBarContributionItem$1.widgetSelected(PerspectiveBarContributionItem.java:92)
at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:90)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:928)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3398)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3022)
at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1916)
at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1880)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:419)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)

Comment 1 Boris Bokowski

2006-11-07 08:46:22 EST

I still see lots of these in my log. (I20061102-1227)

Comment 2 Michael Valenta

2006-11-07 09:11:45 EST

I don't see any in my log. Can you offer any help in identifying what the trigger might be? For instance, do you perform Team>Synchronize a lot?

Comment 3 Boris Bokowski

2006-11-07 09:32:19 EST

CVSHistoryPage.inputSet(CVSHistoryPage.java:1709) calls setFocus, this seems to be the problem:

searchField.setFocus();
 
It appears I have the search field enabled. You cannot call setFocus() on the search field from a part listener.

Comment 4 Michael Valenta

2007-01-11 14:54:25 EST

I removed the call to setFocus

Comment 5 Michael Valenta

2007-02-06 09:02:05 EST

Verified using I20070206-0010