Bugzilla – Full Text Bug Listing
| Summary: | [Markers] Problems View, Errors: must copy whole line | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | John J. Barton <johnjbarton> |
| Component: | IDE | Assignee: | Martin Karpisek <martin.karpisek> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P3 | CC: | eclipse-bugs, Lars.Vogel, markus.kell.r, martin.karpisek |
| Version: | 3.2 | Keywords: | helpwanted, noteworthy |
| Target Milestone: | 4.7 M3 | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| See Also: |
https://git.eclipse.org/r/82656 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=23ebaaa6b197036805bbba45ec2221b7c8bf0b0f https://git.eclipse.org/r/82961 https://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=581b16f4205251ad21d3c948f068b72720f81307 |
||
| Whiteboard: | |||
| Bug Depends on: | 162505, 506240, 506698 | ||
| Bug Blocks: | |||
|
Description
John J. Barton
Please feel free to submit a patch if you have a suggested implementation I think the second problem can be solved by deleting the following lines from
org.eclipse.ui.views.markers.internal.ActionCopyMarker.createMarkerReport():
// create header
for (int i = 0; i < properties.length; i++) {
report.append(properties[i].getDescription());
if (i == properties.length - 1) {
report.append(NEWLINE);
} else {
report.append(DELIMITER);
}
}
A partial workaround for the first problem is to right click on the row in the Problem view and select properties. The values in the Properties dialog work correctly for selection and copy. To fix the first problem the UI elements inside the TreeViewer used by ProblemView would have to be replaced by UI elements like those in the Properties dialog.
Unfortunately the design of ProblemView makes proper clipboard integration difficult. ProblemView isA MarkerView isA TableView. TableView might be more accurately described as ColumnizedAttributedTreeView: The view is visually like a table but behaves like a tree view. The columns of the TableView are not individually selectable and this seems to be a consequence of its use of a TreeViewer. Object selection within the TableView is TreeItem selection, and these items are rows not cells. That's why the copy gives the whole row. One possible direction that would seem most consistent with eclipse would replace TableView's TreeViewer with a TableViewer, which has CellEditor-s with individual Copy actions. I don't know if this would allow character level selection. A different direction would create a simplier View for Problems closer to a Console: lines of text not partitioned into columns. For 80% (or 99%?) of the uses of ProblemView, this simple view would be superior. It would have the same line oriented selection as ProblemView but the text of the Marker would be easily selected at the character level. It would also eliminate the annoying column resize work required by the current ProblemView in favor of a horizontal slider. (Also very annoying, but my guess is that 99% of the time users only need the error text, the rest of the info is given by clicking on the problem and having the IDE position the editor). submitted patch for review: https://git.eclipse.org/r/82656 *** Bug 244965 has been marked as a duplicate of this bug. *** Gerrit change https://git.eclipse.org/r/82656 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=23ebaaa6b197036805bbba45ec2221b7c8bf0b0f Thanks Martin, can you also add an entry to the N&N M3? New Gerrit change created: https://git.eclipse.org/r/82961 added note to 4.7 M3 N&N Gerrit change https://git.eclipse.org/r/82961 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=581b16f4205251ad21d3c948f068b72720f81307 Thanks Martin |