Bugzilla – Full Text Bug Listing
| Summary: | Hard-coded "directory" value in the org.eclipse.hyades.logging.parsers adapter files causes an exception if outputter is enabled | ||||||
|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Suresh Bandanadam <suresh.bandanadam> | ||||
| Component: | TPTP.monitoring | Assignee: | Dave Smith <smith> | ||||
| Status: | CLOSED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P1 | CC: | harkrish, jx_china, labadie, rohit.shetty | ||||
| Version: | unspecified | Keywords: | plan | ||||
| Target Milestone: | --- | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | closed460 | ||||||
| Attachments: |
|
||||||
This needs to be fixed in iteration 3. Raising the severity to critical because it will impact log imports if the harcoded directory does not exist. Upon further review of the code and testing with the latest TPTP 4.3 build (200610090100) I have concluded that there is no problem using the adapter files included with TPTP for the local and remote import scenario. However, to make it easier to consume these adapter files for other purposes such as in standalone mode to write the events to a file by enabling the CBEFileOutputter component, we can change the directory value in the CBEFileOutputter properties to a "." so the user can take the default settings. This is not a high severiy issue that needs to be fixed in 4.3 so I will drop the severity to normal and will target it to 4.4. I'll add information about this issue in the GLA Programming document on the TPTP web site as part of bugzilla 152753 in 4.3. Created attachment 55526 [details]
Patch for this bug
I've attached a patch to this bug that has all the required modifications.
Will commit Aman's patch in 4.4 after reviewing it. Added sizing. Will commit patch in iteration 2 and raising priority to indicate it is planned for 4.4. Committed the fix indicated in the attached patch to TPTP Head CVS. As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open. |
The following hard-coded value for "<pu:Property propertyName="directory" propertyValue="d:\tmp"/>" in all the adapter files (both rules and static) in org.eclipse.hyades.logging.parsers, causes an exception if the specified hard-coded directory is not present. <cc:Outputter description="CBE File Outputter" uniqueID="NE3487F80E9611DB8000DF587DEE0353" disabled="true" type="SingleFileOutputter"> <pu:Property propertyName="directory" propertyValue="d:\tmp"/> <pu:Property propertyName="fileName" propertyValue="example.out"/> <op:SingleFileOutputterType directory="d:\tmp" fileName="example.out"/> </cc:Outputter> It should to be changed to point to the current directory (".")as under: <cc:Outputter description="CBE File Outputter" uniqueID="NE3487F80E9611DB8000DF587DEE0353" disabled="true" type="SingleFileOutputter"> <pu:Property propertyName="directory" propertyValue="."/> <pu:Property propertyName="fileName" propertyValue="example.out"/> <op:SingleFileOutputterType directory="." fileName="example.out"/> </cc:Outputter>