Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 159791

Summary: [Preferences] PreferenceDialogUtil.createPropertyDialogOn should not restrict element to being an IAdaptable
Product: [Eclipse Project] Platform Reporter: Nick Edgar <n.a.edgar>
Component: UIAssignee: Duong Nguyen <duongn>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: jean-michel_lemieux, Tod_Creasey
Version: 3.2Keywords: helpwanted
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Nick Edgar CLA 2006-10-04 15:44:18 EDT
3.2

We have an object that has an associated property page, but the object is not an IAdaptable.  We currently have no proper API for opening the properties dialog on this object.  The closest I could find is PreferenceDialogUtil.createPropertyDialogOn, but the element argument is typed as IAdaptable.  I think this should be relaxed to allow an arbitrary Object.

We currently have a hack workaround whereby we have our own subclass of PropertyDialogAction (marked as not subclassable) with a custom selection provider that returns a selection with our object, and then run the action.  It would be nice to clean this up.
Comment 1 Tod Creasey CLA 2007-06-13 16:28:50 EDT
There are currently no plans to work on this however I would be happy to look over a contribution