Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 159599

Summary: Diff for patches attached to bugs.
Product: Community Reporter: Andrew Niefer <aniefer>
Component: BugzillaAssignee: Eclipse Webmaster <webmaster>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Andrew Niefer CLA 2006-10-03 11:04:46 EDT
On one or two occasions I've seen a Diff link beside a patch attached to a bug.  It comes and goes, and I don't know what causes it to show up.   This link goes to an address something like:
https://bugs.eclipse.org/bugs/attachment.cgi?id=51238&action=diff

The first time I tried this a couple of days ago I got a diff view of the patch, which was cool.  I saw the link again today, and clicking it gave an error:
Can't locate PatchReader/Raw.pm in @INC (@INC contains: . /usr/lib/perl5/5.8.3/ppc-linux-thread-multi /usr/lib/perl5/5.8.3 /usr/lib/perl5/site_perl/5.8.3/ppc-linux-thread-multi /usr/lib/perl5/site_perl/5.8.3 /usr/lib/perl5/site_perl /usr/lib/perl5/vendor_perl/5.8.3/ppc-linux-thread-multi /usr/lib/perl5/vendor_perl/5.8.3 /usr/lib/perl5/vendor_perl) at /home/data/httpd/bugs.eclipse.org/html/bugzilla-2.20/attachment.cgi line 654.

It would be nice if that link was always there and worked.
Comment 1 Eclipse Webmaster CLA 2006-10-03 11:48:54 EDT
This is funny. Is that PatchReader useful at all?  We have 5 servers serving Bugzilla content, and I may have mistakenly installed the PatchReader Perl module on one of the server. Bugzilla must "detect" the presence of PatchReader and add the link dynamically.
Comment 2 Andrew Niefer CLA 2006-10-03 12:11:52 EDT
> Is that PatchReader useful at all?
Its basically the case where I want to look at the patch without bringing it into the eclipse apply patch wizard.  The PatchReader is at least better than looking at the raw patch file.
Comment 3 Eclipse Webmaster CLA 2006-10-03 12:54:29 EDT
I installed PatchReader on all the servers, so the link will always be there, and it will always work.  I think it's a really good feature to have.

D.