Bug 159551

Description Alex 2006-10-03 04:34:21 EDT

I have discovered a case in which the "move" refactoring will incorrectly refactor code (i.e. invalid java code is generated even when starting with valid java code).

The case occurs when moving two or more private static members which are locally referenced to a different class in a different package. A failure case is:

package bar;
public class Bar {
   private static void static1() {
   }
   private static void static2() {
   }
   public void notstatic() {
      static1();
      static2();
   }
}

Now move both static1 and static2 to a class Foo in package foo, which exists but is empty. The following code will be generated (note the two "public" tokens):

package foo;
public class Foo {
   public static void static1() {
   }
   public public static void static2() {
   }
}

This *is* the smallest case that will cause the failure. A single refactoring will *not* cause the problem, and in the absence of the Bar.nonstatic() function, or in the absence of the calls to statc1 and static2 within nonstatic() the failure will *not* arise. If Foo is in the same package as Bar then the failure will *not* arise.

Hope this helps!
-Alex