Bugzilla – Full Text Bug Listing
| Summary: | Get rid of copied HTML rendering classes | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] PDE | Reporter: | Dani Megert <daniel_megert> | ||||
| Component: | UI | Assignee: | Chris Aniszczyk <caniszczyk> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | enhancement | ||||||
| Priority: | P3 | CC: | darin.eclipse, wassim.melhem | ||||
| Version: | 3.0 | ||||||
| Target Milestone: | 3.6 M7 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Bug Depends on: | 157461 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
ok, I'll try not to punt this back to you guys again :) Daniel, for my personal education, how is o.e.j.i.text.html rendering HTML? Is it a 'poor person's browser' or just wraps Browser widget with a fallback for NO_MORE_HANDLES? The classes do the following: - have a control that allows to display HTML in hover (using Browser widget) - code that can generate simple HTML (create lists, paragraphs, etc.) - code that can convert simple HTML to text plus style attributes to be used in StyledText. This is either uses a fallback when the Browser isn't present or when a simple lightweight hover is desired showing HTML Because only a little subset (the one we need) is supported we do not want to make this API. However Ant, PDE and also Debug copied several of our classes and hence I decided to group them together and all x-friends access. fixed. Hi Dani, thanks for the x-friendship olive branch :), but we should exercise tough love between plug-ins. We have a single guideline when it comes to x-friends: x-friends should not cross feature boundaries. While this guideline is not enforced by the runtime nor PDE, it is strongly recommended to follow it for Eclipse to remain a platform for "...nothing in particular". PDE should not get special treatment from Text (platform feature). Neither should JDT, JDT/Debug, etc. Given that the HTMLPrinter has so many clients inside the SDK, IMHO it's worthwhile to make it API. If you are not ready to promote it to API, then I'd prefer if PDE reverted to having their own copy and was removed from the x-friends list. It would not be good idea to set a precedent of violating feature boundaries on the account of this simple case. >Given that the HTMLPrinter has so many clients inside the SDK, IMHO it's
>worthwhile to make it API.
Sorry that won't happen. It is only a fuzzy HTMLPrinter that fits what we need at the moment and we need the freedom to change it at any time.
Sure, let me know when to remove PDE from the list.
Chris, please revert the change. Backed out the changes since Chris is been overworked ;-) Reopening since this was not fixed and maintaining copies is not a good idea. Discussed with Darin and agreed that we will use the x-friend approach here. Created attachment 160474 [details] Fix NOTE: This patch needs functional testing. I quickly tested the XML proposal changes which seem to work but the type proposal is hard to verify since in most cases it never worked at all (see bug 304197). Looks good, I also fixed org.eclipse.pde.ds.ui which had a reference to BrowserInformationControl. Thanks again Dani.
> 20100331
|
> 3.3 M2 PDE has copied several classes from JDT Text and/or Platform Text related to HTML rendering. Since several plug-ins copied the same code Platform Text now offers these classes in an x-friends package: org.eclipse.jface.internal.text.html of which PDE UI is declared as friend. NOTE: before replacing your classes I suggest to check whether they are still in sync. If there are changes ours are probably newer/better.