Bugzilla – Full Text Bug Listing
| Summary: | [PropertiesDialog] 'Resource' and 'Project References' property page fail if modifying closed project | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Dani Megert <daniel_megert> | ||||||
| Component: | UI | Assignee: | Tod Creasey <Tod_Creasey> | ||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | dj.houghton | ||||||
| Version: | 3.3 | ||||||||
| Target Milestone: | 3.3 M3 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Dani Megert
Dani I would like your opinion. This issue is going to happen to lot of pages that are currently out there (including two of the ltk ones at least). I think the best solution is to disable OK on closed projects (with an error message of course). What do you think? >(including two of the ltk ones at least)
Which ones do you mean?
>This issue is going to happen to lot of pages I could not find that many. >disable OK on closed projects In my opinion the correct solution would be to make the controls (or as a general solution the whole page) plus the 'Restore To Defaults' button read-only. Leaving 'Apply' and 'OK' enabled shouldn't hurt since no changes can be made. When you propose readOnly are you suggesting we do a setEnabled(false) on the main control? This would make browsing difficult for things like lists and tables. DJ was also keen on the idea that we just fix our pages - if you think the same we likely should just got this wat. The RefactoringpropertyPage is the one with this problem - I'll log a bug if we go the "fix it all" route. >When you propose readOnly are you suggesting we do a setEnabled(false) on the >main control? No, I wasn't talking about an implementation at that point ;-) i.e. meant: make everything that allows input non-modifiable. I was also thinking along the lines of DJ i.e. don't try to come up with a general solution but just fix the pages that cause problems. >RefactoringpropertyPage How do you make that one appear for closed projects? Please log a bug. The exception below is actually with storing the line delimiter preference. I think fixing the indvidual pages is a better idea. Dani I am trying to figure out how I got the refactoring page for a closed project but I am having a hard time. I'll log a bug when I can replicate. >I'll log a bug when I can replicate. Ah, yeah - that's the 'Refactoring History' property page. It shouldn't even appear. That it does in some cases is covered by bug 154735. Created attachment 50725 [details]
Updared project reference page
Created attachment 50726 [details]
Updated ResourceInfo page
Fixed in build >20060925 Verified in I20060926-0935. |