Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 157445

Summary: [JFace] PopupDialog does not allow direct selection of text in editor
Product: [Eclipse Project] Platform Reporter: Markus Keller <markus.kell.r>
Component: UIAssignee: Susan McCourt <susan>
Status: VERIFIED FIXED QA Contact:
Severity: minor    
Priority: P3    
Version: 3.3   
Target Milestone: 3.4 M6   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on: 152010    
Bug Blocks:    
Attachments:
Description Flags
Fix none

Description Markus Keller CLA 2006-09-15 05:33:44 EDT 
I20060912-0800

When a PopupDialog has focus, the first mouseDown event in another shell is lost. E.g. when you open the Quick Outline (Ctrl+O) in the Java editor and then try to select some text in the editor (without closing the popup), the selection does not work.

This is due to bug 152010. I'll attach a workaround.
Comment 1 Markus Keller CLA 2006-09-15 05:34:46 EDT 
Created attachment 50239 [details]
Fix
Comment 2 Susan McCourt CLA 2006-09-15 13:19:33 EDT 
marking for investigation during 3.3.
Anything affecting the timing of shell activate is risky, so no promises until it can be investigated on all platforms.  In the past, fixing on one platform tends to break another, and there is already some platform-specific code in these scenarios.  Regression testing should include the scenarios from bug #123392.
Comment 3 Susan McCourt CLA 2007-05-01 18:41:13 EDT 
investigate during RC1
Comment 4 Susan McCourt CLA 2007-05-10 15:44:58 EDT 
It's a straightforward change, but unfortunately my Linux and Mac test machines are not easily accessible right now, and I would want to try the scenarios in bug #123392 comment #5 .  I don't see pushing for this in RC1 given the priority/severity.  

I am marking this one for 3.4.  I will be releasing fixes for bugs marked 3.4 during M1 before doing triage on the rest.
Comment 5 Susan McCourt CLA 2007-06-27 12:34:10 EDT 
will address in M2 (when my test lab is set up again)
Comment 6 Susan McCourt CLA 2008-03-17 17:53:39 EDT 
Fixed in HEAD.  Will not be in tomorrow's I-build but will be in M6 builds.
I ran through the scenarios in bug #123392 comment #5 on Windows and all is still well.  Will run through these on Mac and Linux while checking M6 bugs.
Comment 7 Susan McCourt CLA 2008-03-25 12:24:16 EDT 
verified on WinXP, Mac, GTK using I20080324-1800.
Verified that:
- this bug is fixed on all platforms
- the scenarios from bug #123392 comment #5 are unchanged on Mac and Linux. 
- scenario #3 from that bug is different on Windows, now behaving like the Mac.  (dismissing a move/track with esc key dismisses the popup).  This is acceptable (and probably preferred).