Bug 157159

Description Gerhard Schaber 2006-09-13 08:27:35 EDT

When a disabled ActionDelegate is executed by using the corresponding shortcut, the shortcut does not work any more, even when the ActionDelegate is enabled sometime.

The following method is 
public class MyActionDelegate implements IWorkbenchWindowActionDelegate {
  public void selectionChanged(IAction action, ISelection selection) {
     boolean currentState = false;
     ...
     action.setEnabled(currentState);
  }
  ...
}

action is an instance of CommandLegacyActionWrapper (created by ActionDelegateHandlerProxy), if the command is executed by using a shortcut.

If currentState is false sometime when invoking the command, then the CommandLegacyActionWrapper is set disabled and for subsequent uses of the shortcut, Eclipse stops processing the command in Command.executeWithChecks in line 453 (Eclipse 3.2 final):

// Perform the execution, if there is a handler.
if ((handler != null) && (handler.isHandled())) {
  if (!isEnabled()) {
    final NotEnabledException exception = new NotEnabledException(

The state is never updated, no selectionChanged is called subsequently for the MyActionDelegate instance.

The behavior can be reproduced with CDT.
- Assign shortcut Alt-Shift-Z to Refactor/Undo
- Press Alt-Shift-Z if command is disabled
- Rename a piece of code using Refactor/Rename...
- Press Alt-Shift-Z again.

Although Refactor/Rename... is enabled, it will not be executed. If you never press the shortcut when the command is disabled, the shortcuts works fine, ever.