Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 155781

Summary:

[Project Sets] Exported Team Project Sets (.psf) should be sorted

Product:

[Eclipse Project] Platform

Reporter:

Martin Oberhuber <mober.at+eclipse>

Component:

Team

Assignee:

Platform Team Inbox <platform-team-inbox>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

dj.houghton

Version:

3.2

Keywords:

helpwanted

Target Milestone:

3.3 M6

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
patch for org.eclipse.team.ui	none
team.ui jar	none

Description Martin Oberhuber

2006-08-31 05:13:29 EDT

Export > Team Project Set creates a *.psf file. The <project reference="..."/> lines inside the <provider> tag should be sorted on a per-line basis.

Rationale: In an ongoing project, it is common that plugins are added to the psf file over time, and the psf file itself is checked in under version control.

Because the current .psf files are not sorted, every time a plugin is added and the psf file is re-exported, it is hard to verify that the set is still correct: minor modifications change the entire psf file, therefore merging and updating the files is cumbersome. In fact, I have fallen back to sorting the files manually in Emacs before I check them in. This should be done by the export tool already.

Comment 1 Michael Valenta

2006-09-06 13:12:21 EDT

Makes sense. However, we don;t have the manpower to address this in 3.3. Patches will be accepted.

Comment 2 DJ Houghton

2007-03-15 11:06:12 EDT

Created attachment 60953 [details]
patch for org.eclipse.team.ui

Here is a patch which fixes this problem. Rather than using a List to hold the workspace projects, it uses a SortedSet with the comparator set to sort by the lower-case version of the project name.

Comment 3 DJ Houghton

2007-03-15 11:12:12 EDT

Created attachment 60954 [details]
team.ui jar

Martin, here is a new team.ui bundle that you can use which contains the patch. I am using this with Eclipse SDK build i0313.

Comment 4 Michael Valenta

2007-03-15 16:40:23 EDT

Patch released to HEAD. Thanks

Comment 5 Martin Oberhuber

2007-03-16 09:13:48 EDT

Thanks! This will relieve me from post-processing in Emacs.

Comment 6 Michael Valenta

2007-03-20 10:30:16 EDT

verified