Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 15505

Summary:	Variable view: Filter buttons, wrong behaviour
Product:	[Eclipse Project] JDT	Reporter:	Martin Aeschlimann <martinae>
Component:	Debug	Assignee:	Darin Wright <darin.eclipse>
Status:	RESOLVED WONTFIX	QA Contact:
Severity:	normal
Priority:	P3	CC:	Darin_Swanson, jared_burns
Version:	2.0
Target Milestone:	---
Hardware:	PC
OS:	Windows 2000
Whiteboard:

Description Martin Aeschlimann

2002-05-08 06:26:41 EDT

20020502
A pressed button now means 'Show Static' or 'Show field'.

Static Fields should be seen when either 'Show Static' or 'Show field' is 
selected.
The current implementation in the variable view requires both buttons to be 
checked. (->filter behaviour)

Comment 1 Darin Swanson

2002-05-08 08:22:14 EDT

The second button filters final fields not just fields.
Is this the behavior you are seeing?

Comment 2 Martin Aeschlimann

2002-05-08 09:50:33 EDT

What I meant:
 to see final static fields, you have to press both the final fields & the 
static button.
I think, pressing the static button alone should be enough to see all statics.

btw, when stopping at a breakpoint, going to the variable list, it initially 
does not seem to honor the pressed buttons (statics shown even button not 
pressed.(enabling / disabling the button fixed this)

Comment 3 Jared Burns

2002-05-08 09:51:13 EDT

Static fields require the "Show static" button to be selected.
Final fields require the "Show finals" button to be selected.
Static final fields require both buttons to be selected.

This is the correct behavior. Move to close.

Comment 4 Darin Wright

2002-05-08 09:56:00 EDT

I agree, this is the correct behavior. Marking as wont fix.

Comment 5 Martin Aeschlimann

2002-05-08 10:27:56 EDT

Not so fast.
We changed the behaviour from filter to show.
Show means, when enabled something is shown.

If I say show fields, I want to see fields.

Btw, the old behaviour was consistent. Believe me, there were some thoughts 
behind it. I think, we should change back from show to hide.

Comment 6 Darin Wright

2002-05-08 11:06:05 EDT

I guess I am confused, because I claim we are doing what you want:

* the tool/tip action is "Show Static Fields"
* when enabled/pressed, static fields are shown

Is the problem that finals are not shown if they are static unless both buttons 
are pressed?

Comment 7 Martin Aeschlimann

2002-05-08 11:22:00 EDT

Yes, show fields should show all fields, also the static ones.

Comment 8 Martin Aeschlimann

2002-05-08 11:26:36 EDT

oops, sorry, i am confusing again:
Yes, show final fields should show all final fields, also the final static ones.

Comment 9 Jared Burns

2002-05-14 10:41:53 EDT

The current toggle button behavior in the JDT Outliner is wrong.

If you have "Show Statics" selected and "Show Fields" deselected, Static 
fields are shown. If the user turns off "Show Fields" we should not show 
fields.

The correct logic is:
- No fields should be shown if the "Show Fields" toggle is off.
- No statics should be shown if the "Show Statics" toggle is off.

Opened Bug 15946 in JDT UI.