Bug 154799

Description Venkatesh Prasad Ranganath 2006-08-22 21:51:10 EDT

Consider the following snippet 

class A {
  IWorkbench getWorkbench() {
     return PlatformUI.getWorkbench();
  }
}

Since PlatformUI.getWorkbench() is static, pressing Ctrl+Shift+M to add a static import for this method will result in the following snippet

import static org.eclipse.ui.PlatformUI.getWorkbench;

class A {
  IWorkbench getWorkbench() {
     return getWorkbench();
  }
}

Although the resulting code is syntactically correct, it is semantically incorrect -- the result leads to an infinite loop that did not exist in the original snippet.

Hence, when the user invokes "add import" refactoring, the refactoring should check if the method/field referred to in the resulting expression is the same as the one being imported, i.e. check if the defining class of the refered method/field does not change.  If it will change, then the refactoring should flag an error and abort.