Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 154760

Summary: Select Tasks screen of the new server wizard should be improved
Product: [WebTools] WTP ServerTools Reporter: Konstantin Komissarchik <konstantin>
Component: wst.serverAssignee: Tim deBoer <deboer>
Status: CLOSED FIXED QA Contact: Tim deBoer <deboer>
Severity: normal    
Priority: P3    
Version: 1.5   
Target Milestone: 1.5.1 M151   
Hardware: PC   
OS: Windows XP   
See Also: https://git.eclipse.org/r/107951
Whiteboard:
Attachments:
Description Flags
Screen Shot none

Description Konstantin Komissarchik CLA 2006-08-22 17:09:42 EDT
During the WTP 1.5 adoption testing we have noticed a difference between 1.0.x and 1.5 on the Select Tasks screen of the new server wizard. It looks like the task's description text is no longer disabled while the task's checkbox label is still disabled. This looks rather odd since the checkbox looks like a parent ui element and typically disabling parent ui elements should disable children. Will attach a screen shot.

Something should be done to improve this screen. Either we should return to disabling the descriptions or some different ui should be created to better represent task list where some tasks cannot be deselected.
Comment 1 Konstantin Komissarchik CLA 2006-08-22 17:10:58 EDT
Created attachment 48418 [details]
Screen Shot
Comment 2 Tim deBoer CLA 2006-08-22 17:33:32 EDT
This change was due to bug 132758, also from BEA. :) We can't do much in 1.5.1 due to UI freeze. Do you want me to revert to the old behaviour, or do you have another suggestion for minor UI improvement?
Comment 3 Konstantin Komissarchik CLA 2006-08-22 17:42:22 EDT
Funny how that happens. :)

A quick way to improve this without just reverting the 132758 change would be to set the checkbox label to an empty string and use a separate label control. This way the label can stay enabled while the checkbox is selected/disabled. There could be an issue with accessability in doing that. Don't know enough about that to know for sure. If something like that is not possible, I think reverting the 132758 fix would be better than the current behavior.
Comment 4 Tim deBoer CLA 2006-08-23 08:41:59 EDT
AFAIK, using the separate label would be an accessibility problem - screen readers would not read the associated label text when someone selects the checkbox. Do you want to check with Thomas about reverting the other fix, or should I just go ahead?
Comment 5 Konstantin Komissarchik CLA 2006-08-23 09:57:58 EDT
Go ahead with the revert. Thomas is no longer with BEA.
Comment 6 Tim deBoer CLA 2006-08-23 13:37:55 EDT
Ok, will do. Change checked into HEAD.
Comment 7 Konstantin Komissarchik CLA 2006-08-23 14:07:40 EDT
Thanks!
Comment 8 Tim deBoer CLA 2006-08-23 14:40:50 EDT
Released to 1.5.1 and 2.0 streams.
Comment 9 David Williams CLA 2006-09-27 09:07:10 EDT
This is part of a "mass update" where bugs showing "fixed" between 7/1/2006 and 9/27/2006 are assumed fixed in WTP 1.5.1. feel free to change the target milestone if you know a more accurate setting. 
Comment 10 John Lanuti CLA 2007-04-03 11:24:27 EDT
Closing as resolved since 1.5.1.  If this bug should not be closed, please reopen.
Comment 11 Eclipse Genie CLA 2017-10-11 16:04:53 EDT
New Gerrit change created: https://git.eclipse.org/r/107951